Ref. 7290 propagate errors on take_next_data [7292] #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f866f1c to
1bab813
Compare
|
Build status:
|
EduPonz
reviewed
Jan 22, 2020
SubscriberHistory::deserialize_change must return the result of the deserialization and SubscriberHistory::takeNextData should propagate errors on deserialization and removal from history
aac0f97 to
8c01f53
Compare
|
Build status:
|
MiguelCompany
approved these changes
Jan 23, 2020
|
Build status:
|
|
Glitch on Mac CI, relaunched:
|
EduPonz
approved these changes
Jan 23, 2020
IkerLuengo
added a commit
that referenced
this pull request
Feb 21, 2020
This is a port of #962 from 1.9.x SubscriberHistory::deserialize_change must return the result of the deserialization and SubscriberHistory::takeNextData should propagate errors on deserialization and removal from history
MiguelCompany
pushed a commit
that referenced
this pull request
Feb 21, 2020
This is a port of #962 from 1.9.x SubscriberHistory::deserialize_change must return the result of the deserialization and SubscriberHistory::takeNextData should propagate errors on deserialization and removal from history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubscriberHistory::deserialize_change must return the result of the deserialization
and SubscriberHistory::takeNextData should propagate errors on deserialization and removal from history