Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9.x] Correct clang warnings due to overwritten methods [7263] #955

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jan 13, 2020

Backport of #954 to 1.9.x

@EduPonz EduPonz changed the title [1.9.x] Correct clang warnings due to overwritten methods [7236] [1.9.x] Correct clang warnings due to overwritten methods [7263] Jan 13, 2020
MiguelCompany
MiguelCompany previously approved these changes Jan 13, 2020
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@EduPonz EduPonz force-pushed the backport/fix/warnings_performance_tests_mac branch from af72d90 to e2bed5f Compare January 14, 2020 10:13
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@EduPonz
Copy link
Author

EduPonz commented Jan 14, 2020

Failure on Windows toolset v141 due to jenkins expection. The tests have passed.

@MiguelCompany MiguelCompany merged commit 94e31d7 into 1.9.x Jan 14, 2020
@MiguelCompany MiguelCompany deleted the backport/fix/warnings_performance_tests_mac branch January 14, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants