Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing wait_until when time is in the past <1.9.x> [7210] #944

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Fixing wait_until when time is in the past <1.9.x> [7210] #944

merged 2 commits into from
Feb 6, 2020

Conversation

MiguelCompany
Copy link
Member

When TimedConditionVariable::wait_until receives a max_blocking_time in the past, the calculations lead to a negative number on the timespec struct. This leads to EINVAL being returned from pthread_cond_timed_wait.

@MiguelCompany MiguelCompany changed the title [1.9.x] Fixing wait_until when time is in the past. [1.9.x] Fixing wait_until when time is in the past. [7210] Jan 8, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany changed the title [1.9.x] Fixing wait_until when time is in the past. [7210] Fixing wait_until when time is in the past <1.9.x> [7210] Jan 10, 2020
@MiguelCompany MiguelCompany mentioned this pull request Feb 4, 2020
Closed
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany added this to the v1.9.5 milestone Feb 5, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Member Author

Glitch on Mac, relaunching:

  • Mac Build Status

@richiware
Copy link
Member

richiware commented Feb 5, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
    • Code has not been changed for Windows, so failures should not be related.

@richiware richiware merged commit c7b6d93 into 1.9.x Feb 6, 2020
@richiware richiware deleted the hotfix/timed-condition-variable/1.9.x branch February 6, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno left review comments

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiware @ivanpauno