Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid temporary allocations when not using flow controllers <1.9.x> [7274] #943

Merged
merged 13 commits into from
Jan 27, 2020

Conversation

MiguelCompany
Copy link
Member

No description provided.

@MiguelCompany MiguelCompany added this to the v1.9.4 milestone Jan 7, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany modified the milestones: v1.9.4, v1.9.5 Jan 13, 2020
@MiguelCompany MiguelCompany changed the title [1.9.x] Avoid temporary allocations when not using flow controllers Avoid temporary allocations when not using flow controllers <1.9.x> [7274] Jan 13, 2020
@MiguelCompany MiguelCompany force-pushed the feature/throughput-controllers_1.9.x branch from 0bb01be to 6bfde47 Compare January 20, 2020 10:13
IkerLuengo
IkerLuengo previously approved these changes Jan 20, 2020
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany force-pushed the feature/throughput-controllers_1.9.x branch from f3d3714 to 49ab9ed Compare January 23, 2020 13:33
@MiguelCompany MiguelCompany force-pushed the feature/throughput-controllers_1.9.x branch from 49ab9ed to b8fc0b0 Compare January 23, 2020 13:44
IkerLuengo
IkerLuengo previously approved these changes Jan 23, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 83cd23d into 1.9.x Jan 27, 2020
@MiguelCompany MiguelCompany deleted the feature/throughput-controllers_1.9.x branch January 27, 2020 09:49
IkerLuengo added a commit that referenced this pull request Mar 2, 2020
This is a port of #943

* Refs #7013. Uncrustify

* Refs #7013. Templating duplicated code.

* Refs #7013. Reducing number of scheduled timed events.

* Refs #7060. Avoiding usage of RTPSWriterCollector on StatelessWriter.

* Refs #7060. Separated methods on StatefulWriter.

* Refs #7060. Allow separate sending on async wrtiters.

* Refs #7060. Sending separatedly when readers do not share locators.

* Refs #7060. Adding ReaderProxy::change_is_unsent.

* Refs #7060. Sending all fragments when flow controllers not defined.

* Refs #7060. Improving send_changes_separatedly.

* Refs #7060. Fixed failing tests.

* Refs #7060. When history is empty, async thread just sends heartbeat.

* Edit documentation

Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com>
MiguelCompany added a commit that referenced this pull request Mar 4, 2020
* Avoid temporary allocations when not using flow controllers

This is a port of #943

* Refs #7013. Uncrustify

* Refs #7013. Templating duplicated code.

* Refs #7013. Reducing number of scheduled timed events.

* Refs #7060. Avoiding usage of RTPSWriterCollector on StatelessWriter.

* Refs #7060. Separated methods on StatefulWriter.

* Refs #7060. Allow separate sending on async wrtiters.

* Refs #7060. Sending separatedly when readers do not share locators.

* Refs #7060. Adding ReaderProxy::change_is_unsent.

* Refs #7060. Sending all fragments when flow controllers not defined.

* Refs #7060. Improving send_changes_separatedly.

* Refs #7060. Fixed failing tests.

* Refs #7060. When history is empty, async thread just sends heartbeat.

* Edit documentation

Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com>

* GAP improvements from #1031

* Changes sent separately only when requested

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants