-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid temporary allocations when not using flow controllers <1.9.x> [7274] #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
changed the title
[1.9.x] Avoid temporary allocations when not using flow controllers
Avoid temporary allocations when not using flow controllers <1.9.x> [7274]
Jan 13, 2020
MiguelCompany
force-pushed
the
feature/throughput-controllers_1.9.x
branch
from
January 20, 2020 10:13
0bb01be
to
6bfde47
Compare
IkerLuengo
previously approved these changes
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MiguelCompany
force-pushed
the
feature/throughput-controllers_1.9.x
branch
from
January 23, 2020 13:33
f3d3714
to
49ab9ed
Compare
MiguelCompany
force-pushed
the
feature/throughput-controllers_1.9.x
branch
from
January 23, 2020 13:44
49ab9ed
to
b8fc0b0
Compare
IkerLuengo
previously approved these changes
Jan 23, 2020
MiguelCompany
force-pushed
the
feature/throughput-controllers_1.9.x
branch
from
January 27, 2020 07:54
b8fc0b0
to
ce5d6b9
Compare
IkerLuengo
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IkerLuengo
added a commit
that referenced
this pull request
Mar 2, 2020
This is a port of #943 * Refs #7013. Uncrustify * Refs #7013. Templating duplicated code. * Refs #7013. Reducing number of scheduled timed events. * Refs #7060. Avoiding usage of RTPSWriterCollector on StatelessWriter. * Refs #7060. Separated methods on StatefulWriter. * Refs #7060. Allow separate sending on async wrtiters. * Refs #7060. Sending separatedly when readers do not share locators. * Refs #7060. Adding ReaderProxy::change_is_unsent. * Refs #7060. Sending all fragments when flow controllers not defined. * Refs #7060. Improving send_changes_separatedly. * Refs #7060. Fixed failing tests. * Refs #7060. When history is empty, async thread just sends heartbeat. * Edit documentation Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com>
MiguelCompany
added a commit
that referenced
this pull request
Mar 4, 2020
* Avoid temporary allocations when not using flow controllers This is a port of #943 * Refs #7013. Uncrustify * Refs #7013. Templating duplicated code. * Refs #7013. Reducing number of scheduled timed events. * Refs #7060. Avoiding usage of RTPSWriterCollector on StatelessWriter. * Refs #7060. Separated methods on StatefulWriter. * Refs #7060. Allow separate sending on async wrtiters. * Refs #7060. Sending separatedly when readers do not share locators. * Refs #7060. Adding ReaderProxy::change_is_unsent. * Refs #7060. Sending all fragments when flow controllers not defined. * Refs #7060. Improving send_changes_separatedly. * Refs #7060. Fixed failing tests. * Refs #7060. When history is empty, async thread just sends heartbeat. * Edit documentation Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com> * GAP improvements from #1031 * Changes sent separately only when requested Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.