Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.9.x] Removing unnecessary locators when detecting intraprocess only usecase [7041] #917

Merged
merged 2 commits into from
Feb 3, 2020
Merged

[1.9.x] Removing unnecessary locators when detecting intraprocess only usecase [7041] #917

merged 2 commits into from
Feb 3, 2020

Conversation

MiguelCompany
Copy link
Member

No description provided.

@MiguelCompany MiguelCompany changed the title [1.9.x] Removing unnecessary locators when detecting intraprocess only usecase. [1.9.x] Removing unnecessary locators when detecting intraprocess only usecase [7041] Dec 11, 2019
@MiguelCompany MiguelCompany added this to the v1.9.4 milestone Dec 18, 2019
@MiguelCompany MiguelCompany modified the milestones: v1.9.4, v1.9.5 Jan 13, 2020
@MiguelCompany MiguelCompany force-pushed the feature/intraprocess-only-locator-prune_1.9.x branch from 3a7b60e to 8a7350f Compare January 21, 2020 06:07
IkerLuengo
IkerLuengo previously approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MiguelCompany added a commit that referenced this pull request Jan 28, 2020
@MiguelCompany
Removing unnecessary locators when detecting intraprocess only usecase (
10261df 
#917)
@eProsima eProsima deleted a comment from richiware Feb 3, 2020
@MiguelCompany MiguelCompany force-pushed the feature/intraprocess-only-locator-prune_1.9.x branch from 8a7350f to f7394d1 Compare February 3, 2020 13:32
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

IkerLuengo
IkerLuengo approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As good as before

@MiguelCompany MiguelCompany merged commit 844eb7f into 1.9.x Feb 3, 2020
@MiguelCompany MiguelCompany deleted the feature/intraprocess-only-locator-prune_1.9.x branch February 3, 2020 15:43
IkerLuengo added a commit that referenced this pull request Feb 28, 2020
@IkerLuengo
Removing unnecessary locators when detecting intraprocess only usecase
5b47745 
This is a port of #917 from 1.9.x

* Clearing locators when detecting intraprocess only config

* Adding is_intraprocess_only() method to RTPSParticipantImpl
@IkerLuengo IkerLuengo mentioned this pull request Feb 28, 2020
Merged
MiguelCompany pushed a commit that referenced this pull request Feb 28, 2020
@IkerLuengo
Removing unnecessary locators when detecting intraprocess only usecase (
3289274 
#1036)

This is a port of #917 from 1.9.x

* Clearing locators when detecting intraprocess only config

* Adding is_intraprocess_only() method to RTPSParticipantImpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IkerLuengo IkerLuengo IkerLuengo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiware @IkerLuengo