[1.9.x] Reduce proxies memory consumption [7038] #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39b3c07 to
431cf3d
Compare
|
Build status:
|
MiguelCompany
added a commit
that referenced
this pull request
Jan 28, 2020
|
Build status:
|
MiguelCompany
pushed a commit
that referenced
this pull request
Jan 31, 2020
This comes after rebase to #916
MiguelCompany
added a commit
that referenced
this pull request
Feb 4, 2020
* Ref. 5750 XML schema for variable size parameters' max size * Ref. 5750 make data types deserialize themselves * Ref. 5750 Make ParticipantProxyData deserialize its messages * Ref. 5750 Make ReaderProxyData deserialize its messages * Ref. 5750 Make WriterProxyData deserialize its messages * Ref. 5750 avoid allocations on deserialize * Ref. 5750 Make UserData aware of it own size * Ref. 5750 max size-aware ParameterPropertyList_t * Ref. 5750 group data limits in a new struct * Ref. 5750 initialize data limits on WriterProxyData and ReaderProxyData * Ref. 5750 more initialize data limits on WriterProxyData and ReaderProxyData * size limit on PartitionQosPolicy * Ref. 5750 Improve properties' modifications Improve error handling while modifying properties * Ref. 5750 testing dynamic data size limits * Ref. 5750 remove obsolete code * Ref. 5750 Remove unused ParameterList::readParameterListfromCDRMsg * Ref. 5750 correct compilation with security option * Ref. 5750 correct compilations on mocks * Correct compilation warnings * Correct security manager message reading routine * remove compilation warning * Correct valgrind errors * Remove compilation warnings on Windows * Reduce code duplication in CDRMessage::add_string And applying some naming rules * Correct logic error on SerializedPayload::operator== * Uncrustify CDRMessage * Remove unused method on ParameterList * correct string size alignment * Ref. 5750 ParameterType checks size when reading from message * Ref. 5750 Move comon code of reading messages to ParameterLists * Ref. 5750 Removing warnings * Ref. 5750 ProxyDatas don't need data limits anymore This comes after rebase to #916 * Ref. 5750 unused variable warning removal * Refs #7305. Uncrustify ParameterTypes * Refs #7305. Uncrustify QosPolicies. * Refs #7305. Avoid duplicate code on ParameterList.cpp * Refs #7305. Styling on ParticipantProxyData. * Refs #7305. Styling on ReaderProxyData. * Refs #7305. Styling on WriterProxyData. * Refs #7305. Added ParameterList::read_guid_from_cdr_msg. * Refs #7305. Style on ParameterList.cpp * Refs #7305. Using ParameterList::read_guid_from_cdr_msg on PKIDH. * Refs #7305. Style on PKIDH.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
IkerLuengo
added a commit
that referenced
this pull request
Feb 5, 2020
This comes after rebase to #916
IkerLuengo
added a commit
that referenced
this pull request
Feb 6, 2020
This comes after rebase to #916
MiguelCompany
added a commit
that referenced
this pull request
Feb 10, 2020
* Ref. 5750 XML schema for variable size parameters' max size * Ref. 5750 make data types deserialize themselves * Ref. 5750 Make ParticipantProxyData deserialize its messages * Ref. 5750 Make ReaderProxyData deserialize its messages * Ref. 5750 Make WriterProxyData deserialize its messages * Ref. 5750 avoid allocations on deserialize * Ref. 5750 Make UserData aware of it own size * Ref. 5750 max size-aware ParameterPropertyList_t * Ref. 5750 group data limits in a new struct * Ref. 5750 initialize data limits on WriterProxyData and ReaderProxyData * Ref. 5750 more initialize data limits on WriterProxyData and ReaderProxyData * size limit on PartitionQosPolicy * Ref. 5750 Improve properties' modifications Improve error handling while modifying properties * Ref. 5750 testing dynamic data size limits * Ref. 5750 remove obsolete code * Ref. 5750 Remove unused ParameterList::readParameterListfromCDRMsg * Ref. 5750 correct compilation with security option * Ref. 5750 correct compilations on mocks * Correct compilation warnings * Correct security manager message reading routine * remove compilation warning * Correct valgrind errors * Remove compilation warnings on Windows * Reduce code duplication in CDRMessage::add_string And applying some naming rules * Correct logic error on SerializedPayload::operator== * Uncrustify CDRMessage * Remove unused method on ParameterList * correct string size alignment * Ref. 5750 ParameterType checks size when reading from message * Ref. 5750 Move comon code of reading messages to ParameterLists * Ref. 5750 Removing warnings * Ref. 5750 ProxyDatas don't need data limits anymore This comes after rebase to #916 * Ref. 5750 unused variable warning removal * Refs #7305. Uncrustify ParameterTypes * Refs #7305. Uncrustify QosPolicies. * Refs #7305. Avoid duplicate code on ParameterList.cpp * Refs #7305. Styling on ParticipantProxyData. * Refs #7305. Styling on ReaderProxyData. * Refs #7305. Styling on WriterProxyData. * Refs #7305. Added ParameterList::read_guid_from_cdr_msg. * Refs #7305. Style on ParameterList.cpp * Refs #7305. Using ParameterList::read_guid_from_cdr_msg on PKIDH. * Refs #7305. Style on PKIDH.cpp * Refs.7305 Restore API on QosPolicies * Refs #7305. Revert test modifications to old API * apply review suggestions * Ref. 5750 clear QoS instead of reconstruct * Correct indentation * reset 'hasChanged' to default value on clear * correct reading of TypeConsistencyEnforcement * Correct operator= for UserData and Partitions Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the memory consumption of
ReaderProxyandWriterProxyby keeping just the necessary items from the corresponding proxy data.