Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22596] Update submodules when cloning Fast DDS on CI #5558

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[22596] Update submodules when cloning Fast DDS on CI #5558

merged 1 commit into from
Jan 13, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jan 9, 2025 •
edited by juanlofer-eprosima
Loading

Description

This adds submodules: true to the checkout actions on all reusable workflows, making them consistent with the windows one, and thus enabling the IDL parser feature tests.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Tests passed in #5559

@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Jan 9, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima January 9, 2025 15:26
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 9, 2025
juanlofer-eprosima
juanlofer-eprosima previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Refs #22596. Update submodules when cloning Fast DDS on CI
bb1ff44 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany mentioned this pull request Jan 10, 2025
Merged
10 tasks
juanlofer-eprosima
juanlofer-eprosima approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passed in #5559

@MiguelCompany
Copy link
Member Author

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 490e80b into master Jan 13, 2025
3 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/ci-submodules branch January 13, 2025 11:53
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
@MiguelCompany @mergify
Update submodules when cloning Fast DDS on CI (#5558)
665187b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 490e80b)
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
@MiguelCompany @mergify
Update submodules when cloning Fast DDS on CI (#5558)
6e25518 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 490e80b)
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
@MiguelCompany @mergify
Update submodules when cloning Fast DDS on CI (#5558)
a2d14e6 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 490e80b)

# Conflicts:
#	.github/workflows/reusable-mac-ci.yml
#	.github/workflows/reusable-sanitizers-ci.yml
#	.github/workflows/reusable-ubuntu-ci.yml
This was referenced Jan 13, 2025
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
@MiguelCompany @mergify
Update submodules when cloning Fast DDS on CI (#5558)
5fce6f1 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 490e80b)

# Conflicts:
#	.github/workflows/reusable-mac-ci.yml
#	.github/workflows/reusable-sanitizers-ci.yml
#	.github/workflows/reusable-ubuntu-ci.yml
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
@MiguelCompany @mergify
Update submodules when cloning Fast DDS on CI (#5558)
c3d386e 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 490e80b)

# Conflicts:
#	.github/workflows/reusable-mac-ci.yml
#	.github/workflows/reusable-sanitizers-ci.yml
#	.github/workflows/reusable-ubuntu-ci.yml
This was referenced Jan 13, 2025
Open
Open
MiguelCompany added a commit that referenced this pull request Jan 15, 2025
@mergify @MiguelCompany
Update submodules when cloning Fast DDS on CI (#5558) (#5568)
6cf58cb 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 490e80b)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @juanlofer-eprosima