-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22537] Fix EDP reliability timings (backport #5540) #5556
base: 2.14.x
Are you sure you want to change the base?
Conversation
* EDP default configuration should be in milliseconds, not microseconds. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add the timeout for writer->wait_discovery(). Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Refs #22537: test fix Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b53a389) # Conflicts: # src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp
Cherry-pick of b53a389 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no no this one requires change...
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Description
happened to find this miscalculation during ros2/rmw_fastrtps#789.
i believe that comments are the correct values, so that default Duration_t adjusted accordingly in milliseconds.
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5540 done by [Mergify](https://mergify.com).