Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21861] Enable Datasharing segments clean from CLI #5549

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jan 8, 2025

Description

This PR enables to clean Datasharing files from the CLI. It adds a new argument (-f/--force) that will clean all datasharing segments found in the SHM directory. It does NOT check if these files are in use. It is user responsibility to ensure that the CLI is not called with the new argument at runtime, which would cause errors if new endpoints are initialized.
Issue related: #5308

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 8, 2025 13:15
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 8, 2025
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice functionality addition.
Just a NIT that can be applied with skip-ci
I doubt whether we should backport or not

@Mario-DL Mario-DL added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Jan 10, 2025
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Signed-off-by: Carlos Ferreira González <carloos.499@gmail.com>
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cferreiragonz cferreiragonz added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants