Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22277] Split Windows nightly tests using name filter regex #5498

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Dec 16, 2024

Description

This PR splits Fast DDS tests, and runs some of them in parallel, to avoid exceeding the maximum allowed GitHub Workflow time.

Windows Nightly CI run:
https://github.com/eProsima/Fast-DDS/actions/runs/12687477053

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15 rsanchez15 force-pushed the ci/split-tests branch 3 times, most recently from 7094c71 to c046ae9 Compare December 17, 2024 08:01
@rsanchez15 rsanchez15 changed the title Split Windows nightly tests using name filter regex [22277] Split Windows nightly tests using name filter regex Dec 17, 2024
@rsanchez15 rsanchez15 force-pushed the ci/split-tests branch 2 times, most recently from 6c68c7a to 407114a Compare December 17, 2024 14:46
rsanchez15 and others added 5 commits January 8, 2025 16:03
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the ci/split-tests branch 2 times, most recently from 8cc4b2e to ffc2c04 Compare January 9, 2025 09:48
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jan 9, 2025
@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Jan 9, 2025
@MiguelCompany MiguelCompany requested a review from Mario-DL January 9, 2025 10:06
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It is funny that we have a typo in the SecureDiscoveryServer tests.
We will address the failing tests in Debug in a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants