Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22469] Avoid calling setIPv4 in TCPTransportInterface #5492

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Dec 13, 2024

Description

This PR adds a new method copyAddress which allows to copy the whole address of one locator to another. It uses this method to replace the setIPv4 method of TCPTransportInterace introduced in #5382 which caused undesired warnings and misbehavior in TCPv6 cases.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Dec 13, 2024
@cferreiragonz cferreiragonz added this to the v3.2.0 milestone Dec 13, 2024
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima December 13, 2024 11:05
@MiguelCompany MiguelCompany self-requested a review December 13, 2024 12:10
include/fastdds/utils/IPLocator.hpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Show resolved Hide resolved
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running needs-review PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants