[21886] Feature: Windows ci example testing #5397

Mario-DL · 2024-11-12T14:42:40Z

Description

This PR introduces example testing in windows (for the moment, just the hello_world_example) by

Refactoring the current ci example testing so that the docker composes can be used for Linux and Windows.
Creating a new cmake target in which the windows testing image is created with the provided Dockerfile
It also adds a new cli argument to the hello_world example matched so the publisher does not start publishing until it has discovered a minimum of participants.

Follow up work

Include the rest of the examples in the testing.
Maybe separate the windows ci in two jobs: one for building the core library and the other one for testing

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

test/examples/hello_world.compose.yml

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

…ples Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

rsanchez15

LGTM

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL · 2024-11-27T07:28:40Z

@Mergifyio backport 3.1.x 3.0.x

mergify · 2024-11-27T07:28:48Z

backport 3.1.x 3.0.x

✅ Backports have been created

#5425 [21886] Feature: Windows ci example testing (backport #5397) has been created for branch 3.1.x but encountered conflicts
#5426 [21886] Feature: Windows ci example testing (backport #5397) has been created for branch 3.0.x but encountered conflicts

* Refs #21886: Bump windows ci image to 2022 Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add matched argument to hello_world example Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: Add Windows testing Dockerfile Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Refactor CMakeLists example tests and hello_world compose Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: test_hello_world.py fix Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Update docker compose file structure of the rest of examples Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 9c9078f) # Conflicts: # .github/workflows/reusable-windows-ci.yml # versions.md

* Refs #21886: Bump windows ci image to 2022 Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add matched argument to hello_world example Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: Add Windows testing Dockerfile Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Refactor CMakeLists example tests and hello_world compose Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: test_hello_world.py fix Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Update docker compose file structure of the rest of examples Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 9c9078f)

* Run examples in Windows CI (#5397) * Refs #21886: Bump windows ci image to 2022 Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add matched argument to hello_world example Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: Add Windows testing Dockerfile Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Refactor CMakeLists example tests and hello_world compose Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: test_hello_world.py fix Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Update docker compose file structure of the rest of examples Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 9c9078f) * Fix conflicts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21886: Bump windows ci image to 2022 Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Add matched argument to hello_world example Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: Add Windows testing Dockerfile Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Refactor CMakeLists example tests and hello_world compose Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: test_hello_world.py fix Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21886: Update docker compose file structure of the rest of examples Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21886: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL added this to the v3.2.0 milestone Nov 12, 2024

Mario-DL requested review from richiprosima and removed request for richiprosima November 12, 2024 14:43

github-actions bot added the ci-pending PR which CI is running label Nov 12, 2024

Mario-DL changed the title ~~[21886] Feature: Windows ci hello world example testing and refactor~~ [21886] Feature: Windows ci example testing Nov 12, 2024

Mario-DL added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels Nov 13, 2024

Mario-DL commented Nov 13, 2024

View reviewed changes

test/examples/hello_world.compose.yml Show resolved Hide resolved

Mario-DL mentioned this pull request Nov 13, 2024

[21886] Run examples in windows ci playground #5347

Closed

16 tasks

Mario-DL added 7 commits November 26, 2024 12:59

Refs #21886: Bump windows ci image to 2022

a4b9511

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests

0e7ec14

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21886: Add matched argument to hello_world example

e3d34d1

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #21886: Add Windows testing Dockerfile

98bb37e

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21886: Refactor CMakeLists example tests and hello_world compose

c300c3e

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21886: test_hello_world.py fix

53903f0

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21886: Update docker compose file structure of the rest of exam…

7205a26

…ples Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL force-pushed the feature/21886/hello_world branch from e059003 to 7205a26 Compare November 26, 2024 12:01

Mario-DL requested review from rsanchez15 and removed request for rsanchez15 November 26, 2024 12:01

github-actions bot added the ci-pending PR which CI is running label Nov 26, 2024

rsanchez15 previously approved these changes Nov 27, 2024

View reviewed changes

Refs #21886: versions.md

880df48

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL dismissed rsanchez15’s stale review via 880df48 November 27, 2024 06:58

rsanchez15 merged commit 9c9078f into master Nov 27, 2024
3 checks passed

rsanchez15 deleted the feature/21886/hello_world branch November 27, 2024 07:27

mergify bot mentioned this pull request Nov 27, 2024

[21886] Feature: Windows ci example testing (backport #5397) #5425

Merged

12 tasks

mergify bot mentioned this pull request Nov 27, 2024

[21886] Feature: Windows ci example testing (backport #5397) #5426

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21886] Feature: Windows ci example testing #5397

[21886] Feature: Windows ci example testing #5397

Mario-DL commented Nov 12, 2024 •

edited

Loading

rsanchez15 left a comment

Mario-DL commented Nov 27, 2024

mergify bot commented Nov 27, 2024 •

edited

Loading

[21886] Feature: Windows ci example testing #5397

[21886] Feature: Windows ci example testing #5397

Conversation

Mario-DL commented Nov 12, 2024 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

rsanchez15 left a comment

Choose a reason for hiding this comment

Mario-DL commented Nov 27, 2024

mergify bot commented Nov 27, 2024 • edited Loading

✅ Backports have been created

Mario-DL commented Nov 12, 2024 •

edited

Loading

mergify bot commented Nov 27, 2024 •

edited

Loading