Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21828] Warn instead of fail when dds.communication.dynamic_interfaces cannot be built #5310

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 8, 2024

Description

PR #5282 introduces a test which uses docker. If docker executable is not found launches a FATAL_ERROR. This could happens inside a docker container. This PR fixes this changing the FATAL_ERROR to WARNING.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested a review from rsanchez15 October 8, 2024 07:56
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 8, 2024
@richiware richiware changed the title Fix compilation inside docker container with BUILD_TESTING=ON [21828] Fix compilation inside docker container with BUILD_TESTING=ON Oct 8, 2024
@richiware richiware added this to the v3.1.0 - Frozen ❄️ milestone Oct 8, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested review from MiguelCompany and removed request for rsanchez15 October 9, 2024 05:59
@MiguelCompany MiguelCompany changed the title [21828] Fix compilation inside docker container with BUILD_TESTING=ON [21828] Warn instead of fail when dds.communication.dynamic_interfaces cannot be built Oct 9, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 9, 2024
@richiware richiware merged commit 9b680b5 into master Oct 9, 2024
17 checks passed
@richiware richiware deleted the bugfix/21826 branch October 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants