Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making UDP non-blocking send optional [5362] #523

Merged
merged 1 commit into from
May 13, 2019
Merged

Making UDP non-blocking send optional [5362] #523

merged 1 commit into from
May 13, 2019

Conversation

MiguelCompany
Copy link
Member

No description provided.

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Member Author

Windows build passed and then jenkins agent connection failed.

raquelalvarezbanos
raquelalvarezbanos approved these changes May 11, 2019
View reviewed changes
Copy link
Contributor

@raquelalvarezbanos raquelalvarezbanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we add a section to the docs, given that the new parameter can be configured by the user?

@MiguelCompany
Copy link
Member Author

Should we add a section to the docs?

Sure! We should add it to the XML configuration page, and add a paragraph to the transport section.

@richiware richiware merged commit cb44b6b into release/1.8.0 May 13, 2019
@richiware richiware deleted the feature/option-non-blocking-udp branch May 13, 2019 05:12
@richiware
Copy link
Member

The failed job was caused by jenkins failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raquelalvarezbanos raquelalvarezbanos raquelalvarezbanos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiware @raquelalvarezbanos