Fixing some data races and lock ordering [5361] #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelalvarezbanos
suggested changes
May 10, 2019
| @@ -1027,7 +1027,7 @@ bool EDP::pairing_writer_proxy_with_local_reader(const GUID_t& local_reader, con | |||
| bool EDP::pairing_remote_writer_with_local_reader_after_security(const GUID_t& local_reader, | |||
| const WriterProxyData& remote_writer_data) | |||
| { | |||
| std::lock_guard<std::recursive_mutex> pguard(*mp_PDP->getMutex()); | |||
| // std::lock_guard<std::recursive_mutex> pguard(*mp_PDP->getMutex()); | |||
There was a problem hiding this comment.
Do we want to keep this commented out code? (same above)
|
Build status:
|
|
Build status:
|
|
Build status:
|
13e5233 to
099b067
Compare
|
Build status:
|
099b067 to
10370fd
Compare
10370fd to
94163cd
Compare
|
Build status:
|
raquelalvarezbanos
approved these changes
May 13, 2019
|
Build status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.