Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21280] Example refactor: RTPS #5086

Merged
merged 23 commits into from
Jul 23, 2024
Merged

[21280] Example refactor: RTPS #5086

merged 23 commits into from
Jul 23, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jul 18, 2024 •
edited by JesusPoderoso
Loading

Description

This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.
This PR implements the RTPS example which is a simple application intended to demonstrate a basic RTPS deployment.
The main change is that the serialization and deserialization are done with overload methods from fastcdr.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jul 18, 2024
JesusPoderoso
JesusPoderoso suggested changes Jul 21, 2024
View reviewed changes
examples/cpp/rtps_entities/Application.cpp Outdated Show resolved Hide resolved
examples/CMakeLists.txt Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/Application.cpp Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/CMakeLists.txt Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/Application.hpp Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/README.md Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/ReaderApp.cpp Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/WriterApp.hpp Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/WriterApp.cpp Outdated Show resolved Hide resolved
examples/cpp/rtps_entities/WriterApp.cpp Outdated Show resolved Hide resolved
@elianalf elianalf requested a review from JesusPoderoso July 22, 2024 07:20
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 22, 2024
@elianalf elianalf force-pushed the feature/example_refactor/rtps branch from bed9b14 to 62c38f0 Compare July 22, 2024 07:24
@elianalf elianalf changed the title Example refactor: RTPS entities [21280] Example refactor: RTPS entities Jul 22, 2024
@elianalf elianalf requested review from JesusPoderoso and removed request for JesusPoderoso July 22, 2024 07:26
elianalf added 19 commits July 22, 2024 14:37
@elianalf
Refs #21280: Move rtps/Registered example in /rtps_entities
15d314a 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Add application and main
cecdaf7 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Add cliparser
4d3894f 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Change name, guard and extension
ec7bcfd 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Remove old files
beb1016 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Reader application refactor
d196fa8 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Writer application refactor
a688f23 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Make Reader compatible with HelloWorld Publisher and des…
e6eb53d 
…erialize message

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Make reader compatible with helloworld
01297df 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Make writer compatible with helloworld
0b1cc2e 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Add isFull check
fc02c10 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Add tests
94457c3 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Change on writer matched api after rebase
ddd2298 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Add readme file
0c201ec 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Add the idl file in the rtps folder
ad960ec 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Update version.md
1622b62 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Apply suggestion
49c7388 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Uncrustify
abfb777 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Move increase sent sample inside add_change
e2035b2 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/example_refactor/rtps branch from e23976d to 097a635 Compare July 22, 2024 12:38
@elianalf elianalf removed the request for review from JesusPoderoso July 22, 2024 12:38
elianalf added 2 commits July 22, 2024 14:53
@elianalf
Refs #21280: Add missing override
65c4fa9 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21280: Change folder name and delete rtps old folder
1e12cf4 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/example_refactor/rtps branch from 097a635 to 1e12cf4 Compare July 22, 2024 12:59
@elianalf elianalf requested a review from JesusPoderoso July 22, 2024 13:00
@elianalf
Refs #21280: Add override
c200291 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf requested review from JesusPoderoso and removed request for JesusPoderoso July 23, 2024 06:41
JesusPoderoso
JesusPoderoso suggested changes Jul 23, 2024
View reviewed changes
examples/cpp/rtps/ReaderApp.hpp Outdated Show resolved Hide resolved
@elianalf
Refs #21280: Remove unused private variable
c9c2234 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf requested a review from JesusPoderoso July 23, 2024 07:57
JesusPoderoso
JesusPoderoso approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Copy link
Contributor

Triggered manual run for Windows CI (with no test)

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 23, 2024
@elianalf elianalf changed the title [21280] Example refactor: RTPS entities [21280] Example refactor: RTPS Jul 23, 2024
@MiguelCompany MiguelCompany merged commit c2dc6d2 into master Jul 23, 2024
14 of 17 checks passed
@MiguelCompany MiguelCompany deleted the feature/example_refactor/rtps branch July 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @JesusPoderoso @MiguelCompany