Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21267] Add Ubuntu weekly ci (backport #5038) (backport #5054) #5068

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 15, 2024

Description

This PR addresses the following points related to the github CI:

  • Change windows reusable ci to use new merge meta files eProsima CI action
  • Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x
  • move the if (!skip-ci) inside the reusable workflows (as done in other repos with the run-build input), but keep the if (!conflicts) in the PR workflow so the GitHub CI requirement is not satisfied if skipped by conflicts.
  • Refactor ubuntu ci - python build job:
    build packages-select fastdds_python package

@Mergifyio backport 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • N/A Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5038 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #5054 done by [Mergify](https://mergify.com).

@EduPonz EduPonz added this to the v2.6.10 milestone Jul 18, 2024
@EduPonz EduPonz added the to-do label Jul 18, 2024
@github-actions github-actions bot added ci-pending PR which CI is running labels Jul 18, 2024
Mario-DL
Mario-DL previously approved these changes Jul 18, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 18, 2024
mergify bot and others added 2 commits August 7, 2024 12:28
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e6773fb)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 064ce70)
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@github-actions github-actions bot added the ci-pending PR which CI is running label Aug 7, 2024
@JesusPoderoso JesusPoderoso removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Aug 7, 2024
@JesusPoderoso
Copy link
Contributor

CI issues unrelated to the PR.
Ready to merge!

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Aug 8, 2024
@juanlofer-eprosima juanlofer-eprosima merged commit 4945931 into 2.6.x Aug 8, 2024
14 of 17 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the mergify/bp/2.6.x/pr-5054 branch August 8, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants