-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21114] Remove doxygen warnings (#4700, #5011) (backport #5016) #5024
Conversation
Cherry-pick of 28a2e15 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This PR should also include the changes from: |
2e796db
to
ffea8df
Compare
* Refs #21114: Remove doxygen warnings Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Apply Miguel's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 28a2e15) # Conflicts: # include/fastdds/dds/core/policy/QosPolicies.hpp # include/fastdds/dds/publisher/Publisher.hpp # include/fastdds/dds/subscriber/Subscriber.hpp Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
* Refs #21114: Fix dispose Signed-off-by: eduponz <eduardoponz@eprosima.com> Refs #21114: Split return into several @return Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix register_instance Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix unregister_instance Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix read_next_instance_w_condition Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix take_w_condition Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix take_instance Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix take_next_instance Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix take_next_instance_w_condition Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
ffea8df
to
10f88d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR is a manual backport to 2.14.x of two PRs:
This work has been done so the following docs PR passes CI:
Related PRs:
@Mergifyio backport 2.13.x 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist
This is an automatic backport of pull request #5016 done by [Mergify](https://mergify.com).