Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21137] RTPS WriterHistory refactor #4966

Merged
merged 45 commits into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
a091963
Refs #21082. Remove templated version of `new_change`.
MiguelCompany Jun 11, 2024
296f256
Refs #21082. Call simple version of `new_change` in rtps examples.
MiguelCompany Jun 13, 2024
9a5f50b
Refs #21082. Call simple version of `new_change` in `TypeLookupManager`.
MiguelCompany Jun 13, 2024
a7f73d6
Refs #21082. Refactor on EDP.
MiguelCompany Jun 13, 2024
813d8d2
Refs #21082. Refactor on PDP.
MiguelCompany Jun 14, 2024
93df4f5
Refs #21082. Refactor on SecurityManager.
MiguelCompany Jun 14, 2024
2999c0d
Refs #21082. Refactor on unit tests.
MiguelCompany Jun 14, 2024
1e08fac
Refs #21082. Refactor on WLP.
MiguelCompany Jun 14, 2024
0af5811
Refs #21082. Refactor on MonitorService.
MiguelCompany Jun 14, 2024
65ee24b
Refs #21082. Refactor on blackbox tests.
MiguelCompany Jun 14, 2024
1d5eaba
Refs #21082. Fix blackbox tests.
MiguelCompany Jun 17, 2024
88c43f5
Refs #21082. Remove `History::do_reserve_cache`.
MiguelCompany Jun 14, 2024
0a5c27e
Refs #21082. Remove `new_change` overload receiving `std::function`.
MiguelCompany Jun 14, 2024
6c195d2
Refs #21082. Remove `is_pool_initialized`.
MiguelCompany Jun 14, 2024
42368b6
Refs #21082. WriterHistory keeps a change pool.
MiguelCompany Jun 14, 2024
9d60289
Refs #21082. Implementation of `release_change` moved to WriterHistory.
MiguelCompany Jun 14, 2024
5ceda32
Refs #21082. Remove `release_change` from `RTPSWriter`.
MiguelCompany Jun 14, 2024
da8c9cf
Refs #21082. Add `create_change` to `WriterHistory`.
MiguelCompany Jun 17, 2024
d4bc402
Refs #21082. Change calls from `new_change` to `create_change`.
MiguelCompany Jun 17, 2024
161334f
Refs #21082. Remove `new_change` from `RTPSWriter`.
MiguelCompany Jun 17, 2024
7a80559
Refs #21082. Remove `remove_older_changes` from `RTPSWriter`.
MiguelCompany Jun 17, 2024
27fb7ac
Refs #21082. Add payload pool to `WriterHistory`.
MiguelCompany Jun 17, 2024
be46017
Refs #21082. Add new `create_change` overload.
MiguelCompany Jun 17, 2024
163f458
Refs #21082. Using new `create_change` overload where relevant.
MiguelCompany Jun 17, 2024
a433f24
Refs #21082. Refactor on `IPersistenceService`.
MiguelCompany Jun 17, 2024
7a0eced
Refs #21082. Refactor on `DataWriterHistory`.
MiguelCompany Jun 17, 2024
6af2861
Refs #21082. Several methods to create writers removed.
MiguelCompany Jun 17, 2024
75fcd15
Refs #21082. Move data sharing pool initialization to DataWriterImpl.
MiguelCompany Jun 18, 2024
dfa7b83
Refs #21082. Refactor creation of rtps writer.
MiguelCompany Jun 18, 2024
91e0e68
Refs #21082. Refactor PersistentWriter.
MiguelCompany Jun 18, 2024
9e4f645
Refs #21082. Remove constructors taking pools.
MiguelCompany Jun 18, 2024
7b30668
Refs #21082. RTPSWriter does not handle pools.
MiguelCompany Jun 18, 2024
10241f1
Refs #21082. Add pool getters to WriterHistory.
MiguelCompany Jun 18, 2024
72cee5b
Refs #21082. Remove pool references on StatexxxWriter.
MiguelCompany Jun 18, 2024
835b145
Refs #21082. Move pools from `Endpoint` to `BaseReader`.
MiguelCompany Jun 18, 2024
aa3ae1a
Refs #21082. Avoid accessing history attributes.
MiguelCompany Jun 18, 2024
aec5ad9
Refs #21082. Fixes on SecurityManager.
MiguelCompany Jun 18, 2024
84c2c78
Refs #21082. Fix build after rebase.
MiguelCompany Jun 19, 2024
f66a095
Refs #21082. Please linters.
MiguelCompany Jun 19, 2024
ced028c
Refs #21082. Fix release order in `WriterHistory` destructor.
MiguelCompany Jun 19, 2024
c79ba3c
Refs #21082. Move datasharing pool initialization to `RTPSWriter`.
MiguelCompany Jun 19, 2024
1eebb46
Refs #21082. Fix negative tests.
MiguelCompany Jun 19, 2024
fe9a1af
Refs #21137. Apply review suggestions.
MiguelCompany Jun 25, 2024
f614bb3
Refs #21137. Apply suggestions from code review
MiguelCompany Jun 26, 2024
89c4df5
Refs #21137. Add note to versions.md
EduPonz Jun 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refs #21082. Fix build after rebase.
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
  • Loading branch information
MiguelCompany authored and EduPonz committed Jun 27, 2024
commit 84c2c787ceb6fb2f105059b7734a5b6b487fda63
4 changes: 2 additions & 2 deletions src/cpp/rtps/history/WriterHistory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include <mutex>
#include <utility>

#include <fastdds/core/policy/ParameterSerializer.hpp>
#include <fastdds/dds/core/policy/ParameterTypes.hpp>
#include <fastdds/dds/log/Log.hpp>
#include <fastdds/rtps/attributes/HistoryAttributes.hpp>
#include <fastdds/rtps/common/CacheChange.hpp>
Expand All @@ -42,8 +42,8 @@
#include <fastdds/rtps/history/IPayloadPool.hpp>
#include <fastdds/rtps/writer/RTPSWriter.hpp>
#include <fastdds/utils/TimedMutex.hpp>
#include <fastrtps/qos/ParameterTypes.h>

#include <fastdds/core/policy/ParameterSerializer.hpp>
#include <rtps/history/BasicPayloadPool.hpp>
#include <rtps/history/CacheChangePool.h>
#include <rtps/history/PoolConfig.h>
Expand Down
3 changes: 2 additions & 1 deletion src/cpp/rtps/participant/RTPSParticipantImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <sstream>

#include <fastdds/dds/core/ReturnCode.hpp>
#include <fastdds/dds/core/policy/QosPolicies.hpp>
#include <fastdds/dds/log/Log.hpp>
#include <fastdds/LibrarySettings.hpp>
#include <fastdds/rtps/attributes/BuiltinTransports.hpp>
Expand Down Expand Up @@ -1178,7 +1179,7 @@ bool RTPSParticipantImpl::createWriter(
{
*WriterOut = nullptr;

if (param.endpoint.data_sharing_configuration().kind() != DataSharingKind::OFF)
if (param.endpoint.data_sharing_configuration().kind() != dds::DataSharingKind::OFF)
{
EPROSIMA_LOG_ERROR(RTPS_PARTICIPANT, "Data sharing needs a DataSharing payload pool");
return false;
Expand Down