-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21136] Add XML configuration for FlowControllerDescriptor to 2.x (backport #4893) #4905
Conversation
Cherry-pick of e6044e0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Refs #21136: Replace const char* with string Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21136: Update fastRTPS_profiles.xsd Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21136: Implement flow controller descriptor list in XML related source files Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21136: Update tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21136: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21136: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21136: Apply rev Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e6044e0) # Conflicts: # test/unittest/xmlparser/XMLProfileParserTests.cpp # versions.md
* Refs #21054: Revert to const char* for flow controller names Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21054: Handle flow controller names in a XMLParser collection Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21054: Apply Miguel suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21054: Apply second suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
1b0c5af
to
1960117
Compare
@richiprosima please test this |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
CI issues unrelated to the PR. |
Description
This PR is a partial backport from #4837 that brings the XML configuration of the FLow Controller Descriptor List. In
2.x
bothThroughtputController
andFlowcontrollerDescriptor
coexist.@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist
This is an automatic backport of pull request #4893 done by [Mergify](https://mergify.com).