Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First features for safety critical systems #486

Merged
merged 27 commits into from
Apr 11, 2019
Merged

First features for safety critical systems #486

merged 27 commits into from
Apr 11, 2019

Conversation

richiware
Copy link
Member

This PR includes first features for safety critical systems:

  • Preallocated memory for the discovery phase
  • Best effort publisher's write call is now a non-blocking call.

MiguelCompany and others added 24 commits December 26, 2018 16:30
@MiguelCompany @richiware
Fixed size strings [4216] (#361)
dbc32c2 
* Refs #4213. New template fixed_string and unit tests.

* Refs #4213. Changing participant, topic and type name to string_255.

* Refs #4213. Adapting blackbox tests.
@JuanCarlos-Arce @richiware
New Allocation test [4259] (#364)
598c37b 
* Allocation test improved

* Using osrf_testing_tools

* Readme improved.

* Refs #4222 Update the allocation tests to generate a csv file with the results

* Refs #4222 Update the allocation tests to receive a new argument to set a prefix for the output files.

* Refs #4222 Update cmake file to work as the rest of tests

* Refs #4222 Change the output prefix management to set the output file from outside of the program

* Refs #4222 Fix compilation issue.

* Refs #4222 Fix compilation issue.

* Refs #4222 Add a new argument to set the domain of the test

* Refs #4222 Fix compilation issue.

* Refs #4222 Update the csv export process

* Refs #4222. Restoring callgrind related code.

* Refs #4222. Using condition_variable where requested.

* Refs #4222 Fix compilation issue.

* Refs  #4222 Move the include directory on cmakelist file from "test" to "profiling"

* Refs #4259. Added python script to generate plot.

Also allocation tests now appends to csv new data.
@MiguelCompany @richiware
Fixed size bitmaps [4320] (#370)
cd29fc1 
* Refs #4292. Removed get_set from SequenceNumberSet_t.

* Refs #4292. Changed ReaderProxy::get_unsent_changes into for_each_unsent_change.

* Refs #4292. Removed get_requested_changes from ReaderProxy.

* Refs #4292. New template BitmapRange.

* Refs #4292. Using BitmapRange on SequenceNumberSet_t.

* Refs #4292. Using BitmapRange on FragmentNumberSet_t.

* Refs #4292. Added unit tests for BitmapRange.

* Refs #4320. Converting SequenceNumberSet_t into an alias.

* Refs #4320. Fixing compiler warnings.

* Refs #4320. Precalculating max when setting base.
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
a029bae
@MiguelCompany @richiware
Remove ParameterList_t [4370] (#379)
430f352 
* Refs #4306. Refactor for reading parameter list.

* Refs #4306. Refactor for writing ParticipantProxyData.

* Refs #4306. Refactor for writing ReaderProxyData.

* Refs #4306. Refactor for writing WriterProxyData.

* Refs #4306. Refactor for writing inline qos.

* Refs #4306. Remove ParameterList_t.

* Refs #4370. Addressing warnings.

* Refs #4370. Using dynamic_cast when processing parameters.

* Refs #4370. Asserting results of dynamic_cast.

* Refs #4370. Changing inheritance of Parameter_t from private to public.
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
25a5dd1
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
660f601
@MiguelCompany
Refs #4370. Fixing errors compiling on Debug.
3ff2d32
@richiware @MiguelCompany
Mutex wrapper with testing properties [4405] (#383)
181b507 
* Refs #4403. Mutex wrapper with testing properties.

* Refs #4403. Improved doxygen.

* Fixing error initializing on windows.

* Refs #4403. Fixed compilation error on windows.

* Refs #4403. Fixed error in cmakelists.

* Refs #4403. New implementation using LD_PRELOAD.

* Refs #4403. Only tests will run on Linux.

* Refs #4403. Fixed cmake syntax error.

* Refs #4403. Fixed error preloading lib with spaces in dir.

* Refs #4403. Add label NoMemoryCheck to mutex unit tests.

* Refs #4403. Removed blank line.

* Refs #4403. Added support for pthread_mutex_timedlock()
@MiguelCompany @richiware
Resource limited vector [4421] (#386)
a730633 
* Refs #4363. Resource limited vector implementation.

* Refs #4363. Unit tests for resource limited vector.

* Refs #4421. Fixing warnings.

* Refs #4421. Fixing warning on Mac.

* Refs #4421. Improved doxygen doc.

* Refs #4421. Adding a template parameter for the configuration struct.

* Refs #4421. Added all iterator related wrapper methods.

* Refs #4421. Added erase and pop_back wrapper methods.

* Refs #4421. Added element access wrapper methods.

* Refs #4421. Avoiding use of constexpr.
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
95b4fa3
@MiguelCompany @richiware
Writers: Resource limits on the number of matched readers [4570] (#406)
2bf0a7f 
* Refs #4364. Resource limits on RTPSWriter

* Refs #4366. Resource limits for StatelessWriter::m_matched_readers

* Refs #4366. Refactor to remove StatelessWriter::reader_locators in favour of unsent_changes_

* Refs #4366. Tidy up and apply resource limits.

* Refs #4424. Renamed attribute to matched_readers_allocation.

* Refs #4365. ReaderProxy mutex not dynamically created

* Refs #4365. Hiding ReaderProxy internals from MessageReceiver.

* Refs #4365. Removing mutex on ReaderProxy.

* Refs #4365. Using ranged for loops.

* Refs #4365. Reducing calls to set::insert on ReaderProxy.

* Refs #4365. Style and privates on ReaderProxy.

* Refs #4365. Periodic heartbeat code moved to StatefulWriter.

* Refs #4365. Periodic heartbeat uses send_heartbeat_nts.

* Refs #4365. Wakeup of AsyncWriterThread always called from StatefulWriter, never from ReaderProxy.

* Refs #4365. Styling and tidy up.

* Refs #4365. Fixing compile errors on Debug.

* Refs #4365. Resource limiting changes_for_reader on ReaderProxy.

* Refs #4365. Removing dependency of MessageReceiver from the details of the writer.

* Refs #4365. Started refactor towards ReaderProxy reuse.

* Refs #4365. Reusing ReaderProxy instances and controlling the pool size.

* Refs #4365. Fixing warnings.

* Refs #4365. Adding matched_subscriber_allocation to PublisherAttributes

* Refs #4362. Avoiding dynamic allocations on XTypes related parameters

* Refs #4424. Parsing matchedSubscribersAllocation on publisher profiles.

* Refs #4424. XSD profiles file updated.

* Refs #4424. XMLParser unit tests updated.

* Refs #4593. Added FixedSized type.

* Refs #4593. Added some blackbox tests.

* Refs #4570. Removing auto on StatefulWriter.

* Refs #4570. Removing temporary vector on check_acked_status.

* Refs #4570. Fixing warnings.

* Refs #4570. Addressing review comments.

* Refs #4570. Fixing a typo and removing unnecesary includes of ReaderProxy

* Refs #4570. Apply suggestions from code review

Co-Authored-By: MiguelCompany <miguelcompany@eprosima.com>
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
c5f89a4
@MiguelCompany @richiware
Refs #4704. Using matchedSubscribersAllocation on allocations test. (#…
15bea84 
…423)
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
20d6d6e
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
99764dd
@richiware
Merge remote-tracking branch 'origin/develop' into feature/safety-cri…
de9e382 
…tical-systems
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
fb301dc
@richiware
Merge remote-tracking branch 'origin/develop' into feature/safety-cri…
edd523e 
…tical-systems
@richiware
Merge remote-tracking branch 'origin/develop' into feature/safety-cri…
3af1e02 
…tical-systems
@MiguelCompany
Merge branch 'develop' into feature/safety-critical-systems
74e6ab1
@richiware @LuisGP
WIP: Sync write converted to non-blocking call (#426)
c592937 
* Refs #4630. Main mutex was converted to timed version.

* Refs #4630. Removed unused CDRMessagePool.

* Refs #4630. Fixing warnings.

* Refs #4630. Spread max blocking time

* Refs #4630. Refactorization NetworkFactory and UDPTransportInterface.

* Refs #4630. Refactorization TCPTransportInterface.

* Refs #4630. Created TCP keep alive event.

* Refs #4630. Fixing errors with TLS.

* Refs #4630. Fixing errors with TLS.

* Refs #4630. Fixing errors with TLS.

* Refs #4630. Fixing warnings.

* Refs #4630. Fixing invalid read.

* Refs #4630. Debugging clean up.

* Refs #4630. Debugging clean up.

* Refs #4630. Debugging clean up.

* Refs #4630. Debugging clean up.

* Refs #4630. Removing warnings on windows.

* Refs #4630. Removing invalid read.

* Refs #4630 Fixing Windows crash.

* Refs #4630. Applying coding style.

* Refs #4630. Removed lock.

* Refs #4630. Removed shared from lambdas.

* Refs #4630. Invalid read.

* Refs #4630. Invalid read.

* Refs #4630. Invalid read.

* Refs #4630. Invalid read.

* Refs #4630. Using new state.

* Refs #4630. Tired.

* Refs #4630. Change in states.

* Refs #4630. Avoid block.

* Refs #4630. Fixing TLS.

* Refs #4630. Fixed windows warnings.

* Refs #4630. Fixing windows warnings.

* Refs #4630. Avoiding bad shutddown.

* Refs #4630. Applying coding style.

* Refs #4630 Different strands for write/read. Unlock promise if channel was closed before call the async operation.

* Refs #4630. Fixed extra spaces.
Refs #5094 Added ReaderProxyTests (find_change related tests).
30d4d25
Refs #5094 Fixed find_change related bug.
9d0c4c6
@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MiguelCompany MiguelCompany merged commit d155904 into develop Apr 11, 2019
@richiware richiware deleted the feature/safety-critical-systems branch November 21, 2019 08:45
@MiguelCompany MiguelCompany mentioned this pull request Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @MiguelCompany @JuanCarlos-Arce