-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21053] Move DR TypeConsistencyEnforcement & DataRepresentation from TypeConsistency to DataReaderQos #4823
Conversation
…entationQosPolicy to correct place Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job in this PR.
Leaving some corrections and a suggestion. In addition, some considerations:
- I think that the changes in this PR should be reflected in the
versions.md
- As this PR is targeting
3.0.0
, we can break API, which should be left unmarked in the checklist as this PR is breaking. - Before merging this PR it would be nice if we could, at least in local, compile other products. For instance, we should also link a PR to
Shapes Demo
overcoming the API break. - If possible, edit PR's title since
...
seems to be the commit message directly.
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
I think it is correctly checked, see following comment section of the PR template:
|
@richiprosima please test_3 this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green Jenkins CI
@richiprosima please test_3 windows |
Description
This PR updates the DataReaderQoS reformatting the TypeConsistencyQos:
DataReaderQos
shall have:TypeConsistencyEnforcementQosPolicy::type_consistency
DataRepresentationQosPolicy::representation
DataReader::TypeConsistencyQos
shall be removedContributor Checklist
versions.md
file (if applicable).Reviewer Checklist