Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20993] Fix ShmTransport buffer recovery MacOS flaky test #4771

Merged
merged 2 commits into from
May 28, 2024
Merged

[20993] Fix ShmTransport buffer recovery MacOS flaky test #4771

merged 2 commits into from
May 28, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented May 13, 2024 •
edited
Loading

Description

This PR tries to fix a MacOS flaky test by refactoring the behavior of the test.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.14.2 milestone May 13, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 13, 2024
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima May 13, 2024 13:11
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima May 13, 2024 13:30
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima May 14, 2024 07:04
@JesusPoderoso JesusPoderoso modified the milestones: v2.14.2, v3.0.0 May 14, 2024
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima May 14, 2024 09:57
@elianalf elianalf added the to-do label May 20, 2024
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima May 23, 2024 14:11
@JesusPoderoso
Refs #20993: Refactor flaky test
1aade3c 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from MiguelCompany and removed request for richiprosima May 24, 2024 07:42
MiguelCompany
MiguelCompany previously approved these changes May 24, 2024
View reviewed changes
@JesusPoderoso
Refs #20993: Reduce slow sleep to reduce noise in test
b9a9e15 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels May 27, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 27, 2024
MiguelCompany
MiguelCompany approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels May 27, 2024
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 28, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 2e6b169 into master May 28, 2024
10 of 12 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/20993 branch May 28, 2024 06:00
mergify bot pushed a commit that referenced this pull request May 28, 2024
@JesusPoderoso @mergify
Fix ShmTransport buffer recovery MacOS flaky test (#4771)
b235a3a 
* Refs #20993: Refactor flaky test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20993: Reduce slow sleep to reduce noise in test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 2e6b169)
mergify bot pushed a commit that referenced this pull request May 28, 2024
@JesusPoderoso @mergify
Fix ShmTransport buffer recovery MacOS flaky test (#4771)
c0d2ff1 
* Refs #20993: Refactor flaky test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20993: Reduce slow sleep to reduce noise in test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 2e6b169)
This was referenced May 28, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 28, 2024
@JesusPoderoso @mergify
Fix ShmTransport buffer recovery MacOS flaky test (#4771)
10aae72 
* Refs #20993: Refactor flaky test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20993: Reduce slow sleep to reduce noise in test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 2e6b169)
@mergify mergify bot mentioned this pull request May 28, 2024
Merged
10 tasks
mergify bot pushed a commit that referenced this pull request May 28, 2024
@JesusPoderoso @mergify
Fix ShmTransport buffer recovery MacOS flaky test (#4771)
c567956 
* Refs #20993: Refactor flaky test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20993: Reduce slow sleep to reduce noise in test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 2e6b169)
@mergify mergify bot mentioned this pull request May 28, 2024
Closed
10 tasks
EduPonz pushed a commit that referenced this pull request May 28, 2024
@mergify @JesusPoderoso
Fix ShmTransport buffer recovery MacOS flaky test (#4771) (#4855)
67414ce 
* Refs #20993: Refactor flaky test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20993: Reduce slow sleep to reduce noise in test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 2e6b169)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 29, 2024
@mergify @JesusPoderoso
Fix ShmTransport buffer recovery MacOS flaky test (#4771) (#4856)
d280a2d 
* Refs #20993: Refactor flaky test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20993: Reduce slow sleep to reduce noise in test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 2e6b169)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request May 29, 2024
@mergify @JesusPoderoso
Fix ShmTransport buffer recovery MacOS flaky test (#4771) (#4857)
7fc31e7 
* Refs #20993: Refactor flaky test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20993: Reduce slow sleep to reduce noise in test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 2e6b169)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JesusPoderoso @MiguelCompany @elianalf