Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20953] Support Type-Lookup Service with new new GUID-less Discovery Server #4768

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented May 10, 2024

Description

This PR modifies the behavior of TypeLookup service to ensure compatibility with the Discovery Server. Participants now issue the TypeLookupRequest to the participant that sent them the Data (r|w), rather than to the participant containing the endpoint. This adjustment allows servers to respond to their clients, thereby keeping discovery traffic limited to servers. Additionally, it addresses minor changes to improve functionality with the Discovery Server.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally: [20953] Support Type-Lookup Service with new new GUID-less Discovery Server Discovery-Server#78
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v3.0.0 milestone May 10, 2024
@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label May 13, 2024
@cferreiragonz cferreiragonz force-pushed the feature/mesh_ds_guid_less_3.0.x branch from 105294a to a9dfd62 Compare May 13, 2024 08:16
@cferreiragonz cferreiragonz force-pushed the feature/ds_with_type_lookup_service branch from 24fa3fe to 68476c3 Compare May 13, 2024 08:17
@cferreiragonz cferreiragonz force-pushed the feature/mesh_ds_guid_less_3.0.x branch from a9dfd62 to 904b75b Compare May 14, 2024 08:28
@cferreiragonz cferreiragonz force-pushed the feature/ds_with_type_lookup_service branch from 68476c3 to 3774d59 Compare May 14, 2024 08:29
@cferreiragonz cferreiragonz force-pushed the feature/mesh_ds_guid_less_3.0.x branch from 904b75b to 31ff9c1 Compare June 10, 2024 13:26
@cferreiragonz cferreiragonz force-pushed the feature/ds_with_type_lookup_service branch from 3774d59 to a25d707 Compare June 10, 2024 13:27
@cferreiragonz cferreiragonz force-pushed the feature/mesh_ds_guid_less_3.0.x branch 10 times, most recently from 01b4fad to 1113cea Compare June 17, 2024 06:13
@cferreiragonz cferreiragonz force-pushed the feature/mesh_ds_guid_less_3.0.x branch 4 times, most recently from 758babf to b6c63bf Compare June 24, 2024 05:35
@cferreiragonz cferreiragonz force-pushed the feature/mesh_ds_guid_less_3.0.x branch 2 times, most recently from 09e9f9a to 688cd0f Compare June 28, 2024 06:45
Base automatically changed from feature/mesh_ds_guid_less_3.0.x to master July 3, 2024 06:16
@cferreiragonz cferreiragonz force-pushed the feature/ds_with_type_lookup_service branch from a25d707 to 7ec4d31 Compare July 3, 2024 06:38
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima July 3, 2024 06:39
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 3, 2024
@cferreiragonz cferreiragonz force-pushed the feature/ds_with_type_lookup_service branch from 7ec4d31 to 007fae9 Compare July 24, 2024 07:16
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima July 24, 2024 07:20
rsanchez15
rsanchez15 previously approved these changes Jul 24, 2024
…UID instead of proxy_data

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the feature/ds_with_type_lookup_service branch from af21057 to 62a8f0e Compare July 26, 2024 07:06
@rsanchez15 rsanchez15 self-requested a review July 26, 2024 08:43
@rsanchez15 rsanchez15 added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Jul 29, 2024
@rsanchez15 rsanchez15 merged commit fc2fb99 into master Jul 29, 2024
17 checks passed
@rsanchez15 rsanchez15 deleted the feature/ds_with_type_lookup_service branch July 29, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants