-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20119] TCP socket send buffer limit (backport #4237) #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
MiguelCompany
force-pushed
the
mergify/bp/2.6.x/pr-4237
branch
from
January 30, 2024 14:53
b6c7047
to
5fdd345
Compare
This has been rebased on top of #4287, and should be merged after. |
jepemi
force-pushed
the
mergify/bp/2.6.x/pr-4216
branch
from
February 23, 2024 12:12
0786256
to
869217d
Compare
jepemi
force-pushed
the
mergify/bp/2.6.x/pr-4237
branch
from
February 23, 2024 12:16
5fdd345
to
755abc6
Compare
jepemi
force-pushed
the
mergify/bp/2.6.x/pr-4216
branch
from
March 7, 2024 09:27
869217d
to
8c1bfe5
Compare
@jepemi would you mind rebasing on top of |
* Refs #20119: Check send buffer queue before sending new data Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Add non_blocking_send attribute to tcp Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Add test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Add non-blocking send to secure socket Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Update versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: non_blocking_send moved to properties Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20119: Fix Windows&Mac build warnings Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
jepemi
force-pushed
the
mergify/bp/2.6.x/pr-4237
branch
from
March 19, 2024 15:11
755abc6
to
ce11371
Compare
@richiprosima please test this |
Failed tests in github ci unrelated. Ready to merge |
Mario-DL
approved these changes
Mar 25, 2024
Mario-DL
added
the
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
label
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4237 done by Mergify.
Cherry-pick of b5f8c8a has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com