Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19452] Fix 3.0.x workflows #4322

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[19452] Fix 3.0.x workflows #4322

merged 1 commit into from
Jan 30, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jan 30, 2024

Description

#4294 introduced 2 workflows to manage the transition to 3.0, one of them was not according to Github rules, and the other one was not fully correct; This PR fixes both of them.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • [N/A] Check CI results: changes do not issue any warning.
  • [N/A] Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the skip-ci Automatically pass CI label Jan 30, 2024
@EduPonz EduPonz added this to the v3.0.0 milestone Jan 30, 2024
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let us merge and run them manually

@EduPonz EduPonz merged commit c228bd5 into master Jan 30, 2024
11 checks passed
@EduPonz EduPonz deleted the hotfix/3.0.x_workflows branch January 30, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants