-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add large data to Advanced config example #4233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
rsanchez15
requested changes
Jan 12, 2024
examples/cpp/dds/AdvancedConfigurationExample/AdvancedConfiguration_main.cpp
Outdated
Show resolved
Hide resolved
examples/cpp/dds/AdvancedConfigurationExample/AdvancedConfigurationPublisher.cpp
Outdated
Show resolved
Hide resolved
examples/cpp/dds/AdvancedConfigurationExample/AdvancedConfigurationPublisher.cpp
Outdated
Show resolved
Hide resolved
examples/cpp/dds/AdvancedConfigurationExample/AdvancedConfigurationSubscriber.cpp
Outdated
Show resolved
Hide resolved
examples/cpp/dds/AdvancedConfigurationExample/arg_configuration.h
Outdated
Show resolved
Hide resolved
examples/cpp/dds/AdvancedConfigurationExample/arg_configuration.h
Outdated
Show resolved
Hide resolved
examples/cpp/dds/AdvancedConfigurationExample/arg_configuration.h
Outdated
Show resolved
Hide resolved
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
elianalf
force-pushed
the
large_data_advanced_example
branch
from
January 12, 2024 08:08
e130b8f
to
7f13bf1
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
rsanchez15
previously approved these changes
Jan 12, 2024
EduPonz
suggested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should state in the readme of the example that due to the sequence in the data type this example will not use data sharing
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz
suggested changes
Jan 12, 2024
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz
approved these changes
Jan 12, 2024
@richiprosima please test this |
@richiprosima please test mac |
1 similar comment
@richiprosima please test mac |
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds the possibility to send large data with the advanced configuration example. The user can define the size of the message that is sent.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist