Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large data to Advanced config example #4233

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jan 11, 2024

Description

This pr adds the possibility to send large data with the advanced configuration example. The user can define the size of the message that is sent.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added the no-test Skip CI tests if PR marked with this label label Jan 11, 2024
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the large_data_advanced_example branch from e130b8f to 7f13bf1 Compare January 12, 2024 08:08
@elianalf elianalf requested a review from rsanchez15 January 12, 2024 08:10
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
rsanchez15
rsanchez15 previously approved these changes Jan 12, 2024
@EduPonz EduPonz added this to the v2.13.2 milestone Jan 12, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should state in the readme of the example that due to the sequence in the data type this example will not use data sharing

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@EduPonz
Copy link

EduPonz commented Jan 16, 2024

@richiprosima please test this

@elianalf
Copy link
Contributor Author

@richiprosima please test mac

1 similar comment
@elianalf
Copy link
Contributor Author

@richiprosima please test mac

@elianalf elianalf merged commit 77d604d into master Jan 17, 2024
14 checks passed
@elianalf elianalf deleted the large_data_advanced_example branch January 17, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants