Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a pessimizing move. #4202

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Remove a pessimizing move. #4202

merged 1 commit into from
Jan 9, 2024

Conversation

clalancette
Copy link
Contributor

When compiling Fast-DDS with clang, it shows a warning that the use of std::move in FileWatch.hpp is pessimizing. Remove the unnecessary std::move here, which fixes the warning.

Note that this is against the 2.11.x branch, which is what we are using in ROS 2. But I can retarget it to master if that is preferred.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [??] Changes are ABI compatible.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@clalancette
Remove a pessimizing move.
59b8a70 
When compiling Fast-DDS with clang, it shows a warning
that the use of std::move in FileWatch.hpp is pessimizing.
Remove the unnecessary std::move here, which fixes the
warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

Friendly ping on this one, it would be good to get this in! Thanks in advance.

@EduPonz EduPonz merged commit b28171b into eProsima:2.11.x Jan 9, 2024
7 of 13 checks passed
@EduPonz
Copy link

EduPonz commented Jan 9, 2024

Thanks @clalancette for the fix! It does not apply to master as that bit has changed already, but it may apply to other versions, we'll take care of the ports.

@EduPonz
Copy link

EduPonz commented Jan 9, 2024

@Mergifyio backport 2.12.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2024 •
edited
Loading

backport 2.12.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 9, 2024
@clalancette @mergify
Remove a pessimizing move (#4202)
c6a7720 
When compiling Fast-DDS with clang, it shows a warning
that the use of std::move in FileWatch.hpp is pessimizing.
Remove the unnecessary std::move here, which fixes the
warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit b28171b)
@mergify mergify bot mentioned this pull request Jan 9, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
@clalancette @mergify
Remove a pessimizing move (#4202)
24fe8d5 
When compiling Fast-DDS with clang, it shows a warning
that the use of std::move in FileWatch.hpp is pessimizing.
Remove the unnecessary std::move here, which fixes the
warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit b28171b)
@mergify mergify bot mentioned this pull request Jan 9, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
@clalancette @mergify
Remove a pessimizing move (#4202)
2a6eb63 
When compiling Fast-DDS with clang, it shows a warning
that the use of std::move in FileWatch.hpp is pessimizing.
Remove the unnecessary std::move here, which fixes the
warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit b28171b)
@mergify mergify bot mentioned this pull request Jan 9, 2024
Merged
@clalancette clalancette deleted the clalancette/remove-pessimizing-move branch January 9, 2024 20:05
@clalancette
Copy link
Contributor Author

Thanks for the merge!

MiguelCompany pushed a commit that referenced this pull request Jan 10, 2024
@mergify @clalancette
Remove a pessimizing move (#4202) (#4214)
770bdf4 
When compiling Fast-DDS with clang, it shows a warning
that the use of std::move in FileWatch.hpp is pessimizing.
Remove the unnecessary std::move here, which fixes the
warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit b28171b)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
EduPonz pushed a commit that referenced this pull request Jan 12, 2024
@mergify @clalancette
Remove a pessimizing move (#4202) (#4213)
90ce760 
When compiling Fast-DDS with clang, it shows a warning
that the use of std::move in FileWatch.hpp is pessimizing.
Remove the unnecessary std::move here, which fixes the
warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit b28171b)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
EduPonz pushed a commit that referenced this pull request Jan 12, 2024
@mergify @clalancette
Remove a pessimizing move (#4202) (#4212)
438a03b 
When compiling Fast-DDS with clang, it shows a warning
that the use of std::move in FileWatch.hpp is pessimizing.
Remove the unnecessary std::move here, which fixes the
warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit b28171b)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @EduPonz