Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20118] Fix Monitor Service types & test without security #4124

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[20118] Fix Monitor Service types & test without security #4124

merged 4 commits into from
Dec 13, 2023

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Dec 12, 2023 •
edited by EduPonz
Loading

Description

This PR regenerates monitor service types with Fast DDS Gen 3.1.0, updates the corresponding CMakeLists.txt and moves a source file for correcting a compilation issue when compiling the monitor service with SECURITY=OFF

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #20117: Fix security off monitor service test
768f28f 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #20118: Regenerate monitor service types with Fast DDS Gen 3.1.0
dec276b 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #20118: Update CMakeLists.txt
f8e6908 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v2.13.0 milestone Dec 12, 2023
@Mario-DL
Copy link
Member Author

Backwards compatibility run here: https://github.com/eProsima/Fast-DDS-python/actions/runs/7179607420/job/19550139342

@EduPonz
Copy link

EduPonz commented Dec 12, 2023

@richiprosima please test mac

@Mario-DL
Refs #20118: Missing v1 types in unittest
de2071b 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Dec 12, 2023
@EduPonz
Copy link

EduPonz commented Dec 12, 2023

@richiprosima please test this

JesusPoderoso
JesusPoderoso approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit f249561 into master Dec 13, 2023
13 of 14 checks passed
@EduPonz EduPonz deleted the hotfix/monitor-service-compilation branch December 13, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @EduPonz @JesusPoderoso