Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19887] Add missing thread include #4045

Merged
merged 3 commits into from
Nov 27, 2023
Merged

[19887] Add missing thread include #4045

merged 3 commits into from
Nov 27, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Nov 23, 2023 •
edited
Loading

Description

This PR adds missing #include <thread> directives

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Refs #19887: Add missing thread include
d8732aa 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.13.0 milestone Nov 23, 2023
@MiguelCompany
Refs #19887. Update ReturnCode_t comparison operators.
d98f1fd 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@EduPonz
Refs #19887: Uncrustify
bbe67f1 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Copy link
Author

EduPonz commented Nov 24, 2023

@richiprosima please test this

@EduPonz EduPonz merged commit 6390715 into master Nov 27, 2023
8 checks passed
@EduPonz EduPonz deleted the hotfix/thread_include branch November 27, 2023 05:51
@EduPonz EduPonz mentioned this pull request Nov 28, 2023
Merged
@EduPonz
Copy link
Author

EduPonz commented Nov 29, 2023

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Nov 29, 2023
Merged
@mergify mergify bot mentioned this pull request Nov 29, 2023
Merged
@mergify mergify bot mentioned this pull request Nov 29, 2023
Merged
@mergify mergify bot mentioned this pull request Nov 29, 2023
Merged
EduPonz added a commit that referenced this pull request Dec 1, 2023
@EduPonz
Add missing thread include (#4045)
fbd329c 
* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)

# Conflicts:
#	test/blackbox/common/BlackboxTestsPubSubHistory.cpp
#	test/blackbox/common/DDSBlackboxTestsListeners.cpp
#	test/blackbox/common/DDSBlackboxTestsOwnershipQos.cpp
#	test/unittest/dds/publisher/DataWriterTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnLimitedAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnPureSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerSchedulersTests.cpp
#	test/unittest/statistics/rtps/RTPSStatisticsTests.cpp
EduPonz added a commit that referenced this pull request Dec 1, 2023
@EduPonz @MiguelCompany
Add missing thread include (#4045)
c4ce7c8 
* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)

# Conflicts:
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnLimitedAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnPureSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerSchedulersTests.cpp
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Dec 1, 2023
@mergify @EduPonz
Add missing thread include (#4065)
12432cc 
* Add missing thread include (#4045)

* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)

# Conflicts:
#	test/blackbox/common/BlackboxTestsPubSubHistory.cpp
#	test/blackbox/common/DDSBlackboxTestsListeners.cpp
#	test/blackbox/common/DDSBlackboxTestsOwnershipQos.cpp
#	test/unittest/dds/publisher/DataWriterTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnLimitedAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnPureSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerSchedulersTests.cpp
#	test/unittest/statistics/rtps/RTPSStatisticsTests.cpp

* Fix conflicts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Dec 2, 2023
@EduPonz
Add missing thread include (#4045)
4b78c8e 
* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)
EduPonz added a commit that referenced this pull request Dec 3, 2023
@mergify @EduPonz
Add missing thread include (#4045) (#4064)
c561ced 
* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Dec 5, 2023
@mergify @EduPonz @MiguelCompany
Add missing thread include (#4045) (#4062)
402260e 
* Add missing thread include (#4045)

* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)

# Conflicts:
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnLimitedAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnPureSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerSchedulersTests.cpp
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix conflicts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
cferreiragonz pushed a commit that referenced this pull request Dec 5, 2023
@EduPonz @cferreiragonz
Add missing thread include (#4045)
69ef2f5 
* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)

# Conflicts:
#	test/unittest/dds/publisher/DataWriterTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnLimitedAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnPureSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerSchedulersTests.cpp
EduPonz added a commit that referenced this pull request Dec 11, 2023
@mergify @EduPonz @cferreiragonz
Add missing thread include (#4045) (#4063)
7ec5fcb 
* Add missing thread include (#4045)

* Refs #19887: Add missing thread include

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19887. Update `ReturnCode_t` comparison operators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 6390715)

# Conflicts:
#	test/unittest/dds/publisher/DataWriterTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnLimitedAsyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnPureSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerPublishModesOnSyncTests.cpp
#	test/unittest/rtps/flowcontrol/FlowControllerSchedulersTests.cpp

* Fix Conflicts

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: cferreiragonz <carlosferreira@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @MiguelCompany