Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19913] Make test_UDPv4TransportDescriptor non-copyable and non-moveable #4017

Merged
merged 2 commits into from
Nov 14, 2023
Merged

[19913] Make test_UDPv4TransportDescriptor non-copyable and non-moveable #4017

merged 2 commits into from
Nov 14, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 14, 2023 •
edited by Mario-DL
Loading

Description

PR #3994 was merged with warnings in Mac. This PR fixes those warnings by deleting the copy/move constructor/assignment from test_UDPv4TransportDescriptor.

Note: Since backports of #3994 have not yet been merged, it would be a good idea to cherry pick the only commit in this PR to those backports.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • NO Changes are API compatible.
    • Though changes are not API compatible, the transport descriptor is only used for testing purposes, and it is always constructed with std::make_shared, so nothing should break
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.
    • See note, above. Backports will be done manually

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.12.1 milestone Nov 14, 2023
@MiguelCompany
Copy link
Member Author

@richiprosima Please test windows

@MiguelCompany MiguelCompany reopened this Nov 14, 2023
@MiguelCompany
Make test_UDPv4TransportDescriptor non-moveable
9b69270 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany changed the title [19913] Make test_UDPv4TransportDescriptor non-copyable and default moveable [19913] Make test_UDPv4TransportDescriptor non-copyable and non-moveable Nov 14, 2023
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Nov 14, 2023
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

Mario-DL
Mario-DL approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit bb96985 into master Nov 14, 2023
6 of 8 checks passed
@EduPonz EduPonz deleted the hotfix/mac-warnings-test-transport-descriptor branch November 14, 2023 15:45
MiguelCompany added a commit that referenced this pull request Dec 1, 2023
@MiguelCompany
Make test_UDPv4TransportDescriptor non-copyable and non-moveable (#…
c5cb346 
…4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Dec 1, 2023
@MiguelCompany @EduPonz
Make test_UDPv4TransportDescriptor non-copyable and non-moveable (#…
a0723cf 
…4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Dec 1, 2023
@mergify @Mario-DL @MiguelCompany
PubSubAsReliable test fix (#4011)
4883ff0 
* PubSubAsReliable test fix  (#3994)

* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit ded6cd6)

* Make `test_UDPv4TransportDescriptor` non-copyable and non-moveable (#4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Dec 2, 2023
@mergify @Mario-DL @MiguelCompany
PubSubAsReliable test fix (#3994) (#4010)
cb65fcd 
* PubSubAsReliable test fix  (#3994)

* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit ded6cd6)

* Make `test_UDPv4TransportDescriptor` non-copyable and non-moveable (#4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Dec 4, 2023
@MiguelCompany @EduPonz
Make test_UDPv4TransportDescriptor non-copyable and non-moveable (#…
f71e9a0 
…4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Dec 11, 2023
@mergify @Mario-DL @MiguelCompany
PubSubAsReliable test fix (#3994) (#4009)
f8cf460 
* PubSubAsReliable test fix  (#3994)

* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit ded6cd6)

* Make `test_UDPv4TransportDescriptor` non-copyable and non-moveable (#4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @Mario-DL @EduPonz