-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19665] Hotfix TCP sender resources creation #3932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Resource to avoid failing the cast Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@richiprosima please test mac |
richiware
requested changes
Oct 24, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@richiprosima please test this |
richiware
approved these changes
Oct 26, 2023
@Mergifyio backport 2.11.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Refs #19665: Check if casting from a ChainingSender instead of SenderResource to avoid failing the cast Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Regression test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Check if remote WAN sender resource already exists Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19655: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: fix test mac vars init Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Apply Rev suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e94deb8)
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Refs #19665: Check if casting from a ChainingSender instead of SenderResource to avoid failing the cast Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Regression test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Check if remote WAN sender resource already exists Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19655: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: fix test mac vars init Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Apply Rev suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e94deb8)
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Refs #19665: Check if casting from a ChainingSender instead of SenderResource to avoid failing the cast Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Regression test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Check if remote WAN sender resource already exists Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19655: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: fix test mac vars init Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Apply Rev suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e94deb8) # Conflicts: # src/cpp/rtps/transport/TCPSenderResource.hpp # src/cpp/rtps/transport/shared_mem/SharedMemSenderResource.hpp
This was referenced Oct 26, 2023
EduPonz
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Refs #19665: Check if casting from a ChainingSender instead of SenderResource to avoid failing the cast Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Regression test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Check if remote WAN sender resource already exists Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19655: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: fix test mac vars init Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Apply Rev suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e94deb8) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
EduPonz
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Refs #19665: Check if casting from a ChainingSender instead of SenderResource to avoid failing the cast Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Regression test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Check if remote WAN sender resource already exists Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19655: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: fix test mac vars init Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Apply Rev suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e94deb8) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
EduPonz
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Hotfix TCP sender resources creation (#3932) * Refs #19665: Check if casting from a ChainingSender instead of SenderResource to avoid failing the cast Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Regression test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Check if remote WAN sender resource already exists Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19655: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: fix test mac vars init Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19665: Apply Rev suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e94deb8) # Conflicts: # src/cpp/rtps/transport/TCPSenderResource.hpp # src/cpp/rtps/transport/shared_mem/SharedMemSenderResource.hpp * Fix conflicts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an incorrect behavior when a
TCP client
receives the discovery information from aTCP server
with a WAN configured in the locator. It creates more sender resources than needed as it fails to recognize that the ones already created were matching the target ones.@Mergifyio backport 2.11.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist