-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19505] Process environment variables on XML #3841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
added
doc-pending
Issue or PR which is pending to be documented
versions-pending
labels
Sep 12, 2023
MiguelCompany
changed the title
Process environment variables on XML
[19505] Process environment variables on XML
Sep 12, 2023
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
force-pushed
the
feature/xml-environment
branch
from
September 12, 2023 07:42
7d379af
to
ec18a1b
Compare
@richiprosima Please test this |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
force-pushed
the
feature/xml-environment
branch
from
September 12, 2023 09:42
ec18a1b
to
29a2484
Compare
@richiprosima Please test this |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima Please test mac. |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima Please test this |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima Please test this |
MiguelCompany
removed
the
doc-pending
Issue or PR which is pending to be documented
label
Sep 19, 2023
EduPonz
suggested changes
Sep 19, 2023
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
suggested changes
Sep 19, 2023
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@richiprosima please test this |
EduPonz
added
ci-pending
PR which CI is running
and removed
needs-review
PR that is ready to be reviewed
labels
Sep 19, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds environment variables processing on the text values of XML.
This way the user could write something like the following:
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [19583] Add documentation for environment variables expansion on XML Fast-DDS-docs#556
Reviewer Checklist