Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19358] Fix RemoteBuiltinEndpointHonoring blackbox test #3787

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Aug 7, 2023

Description

Making RemoteBuiltinEndpointHonoring less flakey by explicitly checking the entity id of the heartbeats and acknacks sent.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…ants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.12.0 milestone Aug 7, 2023
@MiguelCompany
Copy link
Member Author

@richiprosima Please test mac

@EduPonz EduPonz merged commit d27ad9d into master Aug 11, 2023
@EduPonz EduPonz deleted the hotfix/remote-builtin-enpoint-honouring-test branch August 11, 2023 05:05
@EduPonz
Copy link

EduPonz commented Aug 11, 2023

@Mergifyio backport 2.11.x 2.10.x 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 11, 2023
* Refs #19358. Only account for WLP heartbeats and acknacks.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Change test expectations.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Rename counters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Whitelist localhost to ensure only the two test participants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit d27ad9d)
mergify bot pushed a commit that referenced this pull request Aug 11, 2023
* Refs #19358. Only account for WLP heartbeats and acknacks.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Change test expectations.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Rename counters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Whitelist localhost to ensure only the two test participants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit d27ad9d)
mergify bot pushed a commit that referenced this pull request Aug 11, 2023
* Refs #19358. Only account for WLP heartbeats and acknacks.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Change test expectations.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Rename counters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Whitelist localhost to ensure only the two test participants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit d27ad9d)
jimwang118 pushed a commit to jimwang118/Fast-DDS that referenced this pull request Aug 22, 2023
* Refs #19358. Only account for WLP heartbeats and acknacks.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Change test expectations.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Rename counters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Whitelist localhost to ensure only the two test participants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
EduPonz pushed a commit that referenced this pull request Sep 9, 2023
* Refs #19358. Only account for WLP heartbeats and acknacks.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Change test expectations.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Rename counters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Whitelist localhost to ensure only the two test participants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit d27ad9d)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Sep 9, 2023
* Refs #19358. Only account for WLP heartbeats and acknacks.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Change test expectations.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Rename counters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Whitelist localhost to ensure only the two test participants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit d27ad9d)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Sep 9, 2023
* Refs #19358. Only account for WLP heartbeats and acknacks.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Change test expectations.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Rename counters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19358. Whitelist localhost to ensure only the two test participants communicate.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit d27ad9d)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants