Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19208] Fix ParameterPropertyList increment operators #3739

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[19208] Fix ParameterPropertyList increment operators #3739

merged 2 commits into from
Sep 18, 2023

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Jul 21, 2023 •
edited by Mario-DL
Loading

Description

This PR fixes #1530. It also includes a regression test.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez
Refs #19208: regression test
a4f7e85 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #19208: fix issue 1530
9e2ee6c 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez added this to the v2.12.0 milestone Jul 21, 2023
@JLBuenoLopez JLBuenoLopez mentioned this pull request Jul 21, 2023
Closed
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Aug 18, 2023
Mario-DL
Mario-DL approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed labels Sep 18, 2023
@JLBuenoLopez JLBuenoLopez merged commit 14689a0 into master Sep 18, 2023
@JLBuenoLopez JLBuenoLopez deleted the bugfix/parameterlist_operators branch September 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.

Increment operators of ParameterPropertyList_t iterators seem incorrect [9815]
3 participants
@JLBuenoLopez @Mario-DL @JesusPoderoso