Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19208] Improve script portability #3732

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[19208] Improve script portability #3732

merged 1 commit into from
Sep 19, 2023

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Jul 20, 2023

Description

In order to improve script portability, instead of setting the absolute path to the interpreter, this PR modifies the shebang to make use of /usr/bin/env program. This can have its own portability issues, though it seems that most systems agrees with this convention.

This PR fixes #3734.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [N/A] The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez modified the milestones: v2.11.2, v2.12.0 Jul 20, 2023
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Aug 17, 2023
@EduPonz EduPonz merged commit 61a3239 into master Sep 19, 2023
@EduPonz EduPonz deleted the feature/improve-shebang branch September 19, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants