Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added < and > operators to fixed_string. #3623

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Added < and > operators to fixed_string. #3623

merged 3 commits into from
Jul 18, 2023

Conversation

adriancampo
Copy link
Contributor

@adriancampo adriancampo commented Jun 27, 2023 •
edited by richiware
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@adriancampo adriancampo mentioned this pull request Jul 3, 2023
Merged
richiware
richiware previously approved these changes Jul 5, 2023
View reviewed changes
@richiware richiware added this to the v2.12.0 milestone Jul 5, 2023
@richiware
Copy link
Member

@richiprosima please test this

@adriancampo adriancampo force-pushed the feature/fixed-string-inequality-operators branch from d610407 to 51106bf Compare July 11, 2023 10:47
@adriancampo
Added < and > operators to fixed_string.
87cd6fa 
Signed-off-by: AdrianCampo <adriancampo@eprosima.com>
@adriancampo
Added operators for fixed_string<N>.
8af0941 
Signed-off-by: AdrianCampo <adriancampo@eprosima.com>
@adriancampo
Added tests for new operators.
51106bf 
Signed-off-by: AdrianCampo <adriancampo@eprosima.com>
@richiware
Copy link
Member

@richiprosima please test this

@richiware
Copy link
Member

@richiprosima please test windows

@richiware richiware merged commit 54cc04e into master Jul 18, 2023
@richiware richiware deleted the feature/fixed-string-inequality-operators branch July 18, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adriancampo @richiware