Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18674] Include recently added XML supported tags in the schema #3532

Closed
wants to merge 1 commit into from
Closed

[18674] Include recently added XML supported tags in the schema #3532

wants to merge 1 commit into from

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented May 23, 2023 •
edited by MiguelCompany
Loading

Description

Recent change in the endpoint QoS XML schema (#3492) was not considered while merging new XML schema supported tags (#3399).
This hotfix would include the new definition in both endpoint QoS XML schema.
Test has passed locally

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [18674] Include recently added XML supported tags in the documentation Fast-DDS-docs#494
    To be discussed with @richiware if the documentation should be included or not.
  • N/A Applicable backports have been included in the description.
    Fix introduced manually in the backport PR Support missing tags in XSD [17823] (backport #3399) #3527

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso
Include recently added XML supported tags in the schema
ab10ee6 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label May 23, 2023
@JesusPoderoso JesusPoderoso added this to the v2.11.0 milestone May 23, 2023
@JesusPoderoso JesusPoderoso self-assigned this May 23, 2023
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso changed the title Include recently added XML supported tags in the schema [18674] Include recently added XML supported tags in the schema May 23, 2023
JesusPoderoso added a commit that referenced this pull request May 23, 2023
@JesusPoderoso
Refs #18674: Apply latest fix, #3532
9d445b3 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels May 23, 2023
MiguelCompany pushed a commit that referenced this pull request May 23, 2023
@mergify @richiware @JesusPoderoso
Support missing tags in XSD (#3527)
49deef0 
* Support missing tags in XSD (#3399)

* Refs #17822. Support missing tags

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #17823. Apply suggestion

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 6e654af)

* Refs #18674: Apply latest fix, #3532

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso mentioned this pull request May 24, 2023
Merged
11 tasks
@MiguelCompany
Copy link
Member

We will merge this along with #3534

@MiguelCompany MiguelCompany deleted the hotfix/recent_xml_tag_supported branch May 25, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
needs-review PR that is ready to be reviewed
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @MiguelCompany