Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17873] DomainParticipant::ignore_participant implementation #3412

Merged
merged 13 commits into from
Apr 3, 2023
Merged

[17873] DomainParticipant::ignore_participant implementation #3412

merged 13 commits into from
Apr 3, 2023

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Mar 28, 2023 •
edited by MiguelCompany
Loading

Description

This PR provides the implementation and test for the ignore_participant API call.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jsan-rt jsan-rt changed the title Feature/ignore domain participant/tests [17873] DomainParticipant::ignore_participant implementation Mar 28, 2023
@jsan-rt jsan-rt force-pushed the feature/ignore_domain_participant/tests branch from fb37f02 to fd32364 Compare March 28, 2023 14:20
@sloretz sloretz mentioned this pull request Mar 29, 2023
Closed
8 tasks
@JLBuenoLopez JLBuenoLopez added this to the v2.10.1 milestone Mar 29, 2023
MiguelCompany
MiguelCompany requested changes Mar 29, 2023
View reviewed changes
src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/messages/MessageReceiver.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDP.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/messages/MessageReceiver.cpp Show resolved Hide resolved
src/cpp/fastdds/domain/DomainParticipantImpl.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/messages/MessageReceiver.cpp Show resolved Hide resolved
src/cpp/rtps/participant/RTPSParticipantImpl.cpp Outdated Show resolved Hide resolved
@jsan-rt jsan-rt force-pushed the feature/ignore_domain_participant/tests branch from 43753ef to c8a3bee Compare March 29, 2023 08:31
MiguelCompany
MiguelCompany requested changes Mar 29, 2023
View reviewed changes
src/cpp/rtps/builtin/discovery/participant/PDP.cpp Outdated Show resolved Hide resolved
include/fastdds/rtps/messages/MessageReceiver.h Outdated Show resolved Hide resolved
src/cpp/rtps/participant/RTPSParticipantImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/domain/DomainParticipantImpl.cpp Outdated Show resolved Hide resolved
MiguelCompany
MiguelCompany previously approved these changes Mar 29, 2023
View reviewed changes
jsan-rt added 10 commits March 29, 2023 11:47
@jsan-rt
Refs #17873: Added tests
bbfd95d 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Added implementation
2e684c8 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Modified unsupported test
058b9aa 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Switched default callback calling order
f49446a 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Reevaluate source ignored status after the reception of …
9a6634a 
…an INFO_SRC message

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Added missing callback redirection. Added missing ignore…
727e6d8 
… check after callback

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Reintroduced remove_remove_participant into ignore_parti…
5394601 
…cipant. Applied suggestions

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Changed the ignore_participant return type. Applied more…
a00fe6c 
… suggestions

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Extended PDPListener modifications to PDPServerListener
752051d 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Updated versions.md
3f62905 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt force-pushed the feature/ignore_domain_participant/tests branch from 7b8e929 to 3f62905 Compare March 29, 2023 09:55
@jsan-rt jsan-rt marked this pull request as ready for review March 29, 2023 09:57
@jsan-rt
Copy link
Contributor Author

jsan-rt commented Mar 29, 2023

@richiprosima please test this

@jsan-rt
Copy link
Contributor Author

jsan-rt commented Mar 29, 2023

@richiprosima please test windows

1 similar comment
@MiguelCompany
Copy link
Member

@richiprosima please test windows

EduPonz
EduPonz suggested changes Mar 31, 2023
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one thing missing on this PR: Discovery Server Clients should not be able to ignore their own servers

@jsan-rt
Refs #17873: Prevented participants from ignoring their own discovery…
20774e6 
… servers

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #17873: Further improved filtering
149f9e8 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
MiguelCompany
MiguelCompany previously approved these changes Mar 31, 2023
View reviewed changes
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Mar 31, 2023
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Apr 2, 2023
EduPonz
EduPonz previously approved these changes Apr 2, 2023
View reviewed changes
@jsan-rt
Refs #17873: Removed unsupported from doxydoc
198377b 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt dismissed stale reviews from EduPonz and MiguelCompany via 198377b April 3, 2023 06:26
@MiguelCompany MiguelCompany added ci-pending PR which CI is running and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Apr 3, 2023
@jsan-rt jsan-rt mentioned this pull request Apr 3, 2023
Merged
@MiguelCompany MiguelCompany merged commit 924593a into master Apr 3, 2023
@MiguelCompany MiguelCompany deleted the feature/ignore_domain_participant/tests branch April 3, 2023 08:54
@MiguelCompany MiguelCompany mentioned this pull request Apr 4, 2023
Merged
8 tasks
@vfrcode vfrcode mentioned this pull request Apr 16, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@EduPonz EduPonz EduPonz left review comments

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jsan-rt @MiguelCompany @EduPonz @JLBuenoLopez