Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Revert #2785 #2870

Closed
wants to merge 8 commits into from
Closed

WIP Revert #2785 #2870

wants to merge 8 commits into from

Conversation

Blast545
Copy link

@Blast545 Blast545 commented Jul 21, 2022 •
edited
Loading

Description

It seems this commit introduced various build regressions on the nightly_win_deb jobs of the ROS2 buildfarm.
Reference: https://ci.ros2.org/view/nightly/job/nightly_win_deb/2425/
Issue: ros2/geometry2#543

It was a flaky hang that appeared not so often, but now it has happened three times in a row. We are checking if this PR solves the hang situation.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Blast545 added 8 commits July 21, 2022 11:14
@Blast545
Revert "Add new CMake option to allow users to enforce use of our thi…
a256f0a 
…rd party shared_mutex (eProsima#2846)"

This reverts commit dee1d4b.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Revert "Fix wrong usage of std::remove_if (eProsima#2853)"
ad83138 
This reverts commit 9bba04f.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Revert "Fix acknowledge in Datasharing (eProsima#2845)"
ebc7a36 
This reverts commit 3adb35d.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Revert "Store EDP listener pointers before being used (eProsima#2857)"
0060fdd 
This reverts commit 0014b01.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Revert "Improve rediscovery on lossy environments (eProsima#2838)"
8e2e141 
This reverts commit fb790b0.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Revert "Fixed validation on ParameterPropertyList_t (eProsima#2837)"
d074a10 
This reverts commit 50c1ee5.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Revert "Added check to prevent dereferencing end() iterator (eProsima…
364dd95 
…#2851)"

This reverts commit ede9a12.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Revert "Improve read/take performance (eProsima#2785)"
21b8c80 
This reverts commit 8578614.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@MiguelCompany
Copy link
Member

@Blast545 Could you check with #2868? It fixes an access on a deleted object when deleting a Topic.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jul 21, 2022
@MiguelCompany
Copy link
Member

@richiprosima please test this

@Blast545
Copy link
Author

FYI: @Crola1702

@Blast545
Copy link
Author

@Blast545 Could you check with #2868? It fixes an access on a deleted object when deleting a Topic.

Yes, I will! We were still verifying if we were able to reproduce the error with current main.

@Blast545
Copy link
Author

We weren't able to replicate this problem when we started testing this PR, and the problem hasn't appeared again in our buildfarms.

Probably the problem was fixed after: #2868, Thanks!

@Blast545 Blast545 closed this Jul 26, 2022
@MiguelCompany
Copy link
Member

Probably the problem was fixed after: #2868, Thanks!

Either that or #2851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blast545 @MiguelCompany