Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13326] Update types using last Fast DDS Gen v2.1.0 release candidate #2376

Merged
merged 11 commits into from
Dec 23, 2021
Merged

[13326] Update types using last Fast DDS Gen v2.1.0 release candidate #2376

merged 11 commits into from
Dec 23, 2021

Conversation

JLBuenoLopez
Copy link
Contributor

Use Fast DDS Gen generated files directly

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

@JLBuenoLopez
Refs #13326: update types using last Fast DDS Gen v2.1.0 release cand…
a67828c 
…idate. Use Fast DDS Gen generated files directly

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez added this to the v2.5.0 milestone Dec 22, 2021
@MiguelCompany
Copy link
Member

This does not build on Mac: http://jenkins.eprosima.com:8080/view/Fast%20DDS/job/fastdds_mac/1475/

@MiguelCompany
Copy link
Member

MiguelCompany commented Dec 22, 2021 •
edited
Loading

  • uncrustify: Build Status
  • Mac: Build Status
  • Linux: Build Status
  • Windows: Build Status

@JLBuenoLopez
Refs #13326: rename String structure to StringTest
c0cb284 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #13326: linters
a343f0e 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Copy link
Contributor Author

JLBuenoLopez commented Dec 22, 2021 •
edited
Loading

Uncrustify failures are autogenerated files.

JLBuenoLopez and others added 5 commits December 22, 2021 16:37
@JLBuenoLopez
Refs #13326: operator == const
a20ec2c 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@MiguelCompany
Fixed typo
cb41c1b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@EduPonz
Refs 13326: Fix BlackboxTests_RTPS.RTPSCustomPools.RTPSAsReliableWith…
10e4a8d 
…Registration* tests

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 13326: Fix TCP tests
ecbe188 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 13326: Fix static discovery blackbox tests
2507b7b 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
JLBuenoLopez
JLBuenoLopez commented Dec 23, 2021
View reviewed changes
Copy link
Contributor Author

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but being the PR author I cannot approve them

jsan-rt
jsan-rt previously approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me too. Approved.

@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Dec 23, 2021
@EduPonz
Refs 13326: Fix Fast RTPS tests
2f0a2e7 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 13326: Uncrustify
20cdf1c 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 13326: Fix Windows Warnings
5fed112 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
jsan-rt
jsan-rt approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 4054a7c into master Dec 23, 2021
@EduPonz EduPonz deleted the feature/update-types branch December 23, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JLBuenoLopez @MiguelCompany @jsan-rt @EduPonz