Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2370 #2371

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Fix #2370 #2371

merged 1 commit into from
Dec 22, 2021

Conversation

MiguelCompany
Copy link
Member

This should fix #2370 by changing the privacy of the linker option to always private

@MiguelCompany
Fix #2370
74bc34f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 labels Dec 22, 2021
@MiguelCompany MiguelCompany added this to the v2.5.0 milestone Dec 22, 2021
@MiguelCompany MiguelCompany mentioned this pull request Dec 22, 2021
Closed
EduPonz
EduPonz approved these changes Dec 22, 2021
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that this indeed solves it

@MiguelCompany MiguelCompany merged commit 7028087 into master Dec 22, 2021
@MiguelCompany MiguelCompany deleted the hotfix/linker-options-private branch December 22, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

CMake: Should VERSION_SCRIPT_SUPPORT_FLAGS always be PRIVATE?
2 participants
@MiguelCompany @EduPonz