Avoid logWarning when environment file filename is empty [13302] #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
MiguelCompany
requested changes
Dec 20, 2021
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids a
logWarningthat was issued wheneverDomainParticipantFactory::load_profiles()was called for the first time without settingFASTDDS_ENVIRONMENT_FILEenvironment variable or setting it to"". It also adds a regression test and a test that checks that thelogWarningis indeed issued ifFASTDDS_ENVIRONMENT_FILEis set to an non-existing file.