Add participant locators if new network interfaces are found [12753] #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
EduPonz
suggested changes
Dec 15, 2021
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
EduPonz
suggested changes
Dec 16, 2021
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
|
@richiprosima Please test this |
3 similar comments
|
@richiprosima Please test this |
|
@richiprosima Please test this |
|
@richiprosima Please test this |
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
EduPonz
approved these changes
Dec 17, 2021
EduPonz
pushed a commit
that referenced
this pull request
Dec 20, 2021
…2361) * Refs #12754: refactor get default locators when not provided by the user Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12754: update interfaces RTPS layer Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12754: link to dds layer Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12754: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12754: fix failing Participant tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12754: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12754: ensure PDP update Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12754: linters. Remove traces Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: override NormalizeLocator test_UDPv4Transport Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: add API to RTPS Blackbox Reader & Writer Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: add RTPS Blackbox test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: drop unicast packets if simulating no interfaces Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: only run Transport case Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: improve test documentation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: add DDS blackbox test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: improve test documentation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12753: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only network interfaces found when launching Fast DDS are taken into account. This PR adds new participant locators if new network interfaces are detected. In order to trigger the check, the user must call
DomainParticipant::set_qos. If some user is using the RTPS layer directly, the feature can also be triggered by callingRTPSParticipant::update_attributes.This PR includes both the implementation and the Blackbox tests at RTPS and DDS level. It also completes test API, both in the Entities as in the Transport layer.
Related PRs: