Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for DDS Examples #2329

Merged
merged 7 commits into from
Nov 26, 2021
Merged

Fixes for DDS Examples #2329

merged 7 commits into from
Nov 26, 2021

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Nov 26, 2021

This PR fixes some installation issues for the DDS Examples

@EduPonz
Refs 12883: Rename UseCaseDemostrator to Configurability
5a40362 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 12883: Install WriterLoansExample in correct directory
d56bd13 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 12883: Install ZeroCopyExample in correct directory
5c0b7b5 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 12883: Install HelloWorldSubscriber.xml from StaticHelloWorldExa…
819c4f5 
…mple

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 12883: Clean up legacy files in OwnershipStrengthQoSExample
c19f327 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 12883: Uncrustify
d426120 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
JLBuenoLopez
JLBuenoLopez reviewed Nov 26, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a small nitpick

examples/C++/DDS/Configurability/README.txt Outdated Show resolved Hide resolved
@EduPonz
Refs 12883: Apply suggestion
eae41cf 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI and removed no-test Skip CI tests if PR marked with this label labels Nov 26, 2021
@EduPonz
Copy link
Author

EduPonz commented Nov 26, 2021

I've added the skip-ci label since the changes only affect examples

JLBuenoLopez
JLBuenoLopez approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 7a8a0f4 into master Nov 26, 2021
@EduPonz EduPonz deleted the hotfix/dds-examples branch November 26, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @JLBuenoLopez