Fix read after free on security code when remote participant is gone before an endpoint is matched [13035] #2328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a remote writer is discovered (SecurityManager::discovered_writer), the cryptohandle for this remote writer is
stored in local_reader->second.associated_writers.
But the writer is not matched with the local reader after the key exchange process finish.
If meantime the participant is unregistered, all crypthandle of its remote endpoints are removed.
But the local_reader still maintains a pointer, because this pointer is only removed when the reader unmatched with the
remote writer.
Then, when the local participant is deleted, SecurityManager access to this invalid reference.
This PR fixes this.