Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 2.4.1 [13029] #2326

Merged
merged 4 commits into from
Nov 25, 2021
Merged

Bump version to 2.4.1 [13029] #2326

merged 4 commits into from
Nov 25, 2021

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 25, 2021 •
edited
Loading

Bumping version and updating QD for foonathan memory.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Nov 25, 2021
@MiguelCompany MiguelCompany added this to the v2.4.1 milestone Nov 25, 2021
@MiguelCompany MiguelCompany changed the title Bump version to 2.4.1 [12883] Bump version to 2.4.1 [13029] Nov 25, 2021
@MiguelCompany MiguelCompany marked this pull request as ready for review November 25, 2021 11:09
MiguelCompany and others added 3 commits November 25, 2021 12:13
@MiguelCompany
Refs 13029. Point Windows CI badges to last toolset.
1f78501 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13029. Bump version.
76ca104 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13029. Update foonathan QD.
964ba3e 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
JLBuenoLopez
JLBuenoLopez previously approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nitpick and I am OK leaving it as it is now

Quality_Declaration_foonathan_memory.md Outdated Show resolved Hide resolved
@MiguelCompany
Refs 13029. Update foonathan QD (commit/release).
dde7ebb 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
JLBuenoLopez
JLBuenoLopez approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelCompany MiguelCompany merged commit b79d11d into master Nov 25, 2021
@MiguelCompany MiguelCompany deleted the release/2.4.1 branch November 25, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @JLBuenoLopez