Fix various gcc11 warnings [12970] #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the pid always has a value, and gets rid of a gcc 11 warning about pid being possibly uninitialized. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Since this can fail, the return value (in the last parameter) may not get set. Always check the return value, which gets rid of some warnings with gcc 11. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
gcc 11 pointed out that we could sometimes return a stack pointer from within sqlite3SelectNew(). That could only happen in Release mode (where asserts are disabled), but that is still a problem. I took a look at upstream sqlite3 (3.36), and saw that this had already been fixed. This is a backport of just that fix. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
gcc 11 points out that the array of ListenerStatus structures are not POD types, and so using a simple memset on them could be dangerous. Instead, switch to 'std::fill_n' with this, which necessitated adding some new constructors to the non-POD types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
@richiprosima Please test this |
1 similar comment
|
@richiprosima Please test this |
|
Failures are all known flakey tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #2321 to the master branch