Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zero-valued InstanceHandle_t [12942] #2316

Merged
merged 9 commits into from
Nov 30, 2021
Merged

Allow zero-valued InstanceHandle_t [12942] #2316

merged 9 commits into from
Nov 30, 2021

Conversation

MiguelCompany
Copy link
Member

This should fix #2306 by adding a specific validity field to InstanceHandle_t. This means the solution is not ABI compatible with the current code. That's why I added this to v2.5.0 milestone.

@MiguelCompany MiguelCompany added this to the v2.5.0 milestone Nov 15, 2021
@MiguelCompany MiguelCompany mentioned this pull request Nov 15, 2021
Closed
@MiguelCompany MiguelCompany changed the title Add explicit is_defined_ field on InstanceHandle_t Add explicit is_defined_ field on InstanceHandle_t [12942] Nov 15, 2021
@MiguelCompany
Refs 12862. Changed test to use zero-valued valid key.
cb3d93a 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12862. Added KeyHash_t.
d79a802 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12862. Added InstanceHandleValue_t.
24dd321 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12862. Using InstanceHandleValue_t on InstanceHandle_t.
5ab1a2b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12862. Comparison operators on InstanceHandleValue_t.
d9a710c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12862. Added noexcept where appropiate.
4032ef5 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12942. Using empty initializer list.
11bd40c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@richiprosima Please test mac

@MiguelCompany
Refs 12942. Doxygen on InstanceHandleValue_t.
8aa0a8d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
richiware
richiware previously approved these changes Nov 30, 2021
View reviewed changes
@MiguelCompany MiguelCompany changed the title Add explicit is_defined_ field on InstanceHandle_t [12942] Allowing zero-valued InstanceHandle_t [12942] Nov 30, 2021
@MiguelCompany MiguelCompany changed the title Allowing zero-valued InstanceHandle_t [12942] Allow zero-valued InstanceHandle_t [12942] Nov 30, 2021
@MiguelCompany MiguelCompany added no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label and removed no-aarch Skip build & test for aarch64 labels Nov 30, 2021
@MiguelCompany
Refs 12942. Including change on versions.md.
0e6d853 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany merged commit cd7968e into master Nov 30, 2021
@MiguelCompany MiguelCompany deleted the bugfix/key-value-zero branch November 30, 2021 14:29
@MiguelCompany MiguelCompany mentioned this pull request Dec 1, 2021
Merged
@JesusPoderoso JesusPoderoso mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware left review comments

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

A reader receives RETCODE_NO_DATA with keyed topics when the value of the key is zero [12862]
2 participants
@MiguelCompany @richiware