Disable DataReader on destruction [12870] #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
|
@Mergifyio backport 2.3.x |
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2021
* Refs #12870: Disable datareader on destruction Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs #12870: Protect RTPSReader::setListener Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit d4de4a1)
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the
DataReaderon destruction. This is because, as reported in #2307 , it could be the case that a data sample is received while deleting aDataReader, which before could end up in a situation in which the underlyingRTPSReaderwas accessed when it had been already deleted. To avoid this case, the first thing done on the destruction of theDataReaderis to disable it, which sets theDataReaderandRTPSReaderlisteners tonullptr, thus preventing receiving a data sample on upper layers.Closes #2307